feat: update grammar and highlight #3050
Merged
+19
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
Contributor
|
Skipped: This PR does not contain any of your configured keywords: ( |
Comment on lines
+1
to
+2
| export const S_EXPRESSION_LANGUAGE_ID = 's-expression_unstable'; | ||
| export const YQL_LANGUAGE_ID = 'yql_unstable'; |
Member
There was a problem hiding this comment.
Could you please comment, why we use _unstable versions?
Contributor
Author
There was a problem hiding this comment.
Could you please comment, why we use
_unstableversions?
It's an experiment - we're going to use monarch highlight, that is generated by YQL backend team. For now it's stable enough to try it in YDB (it's been using in YQL for 1 month), to not stable enough to call it stable :)
artemmufazalov
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
closes ydb-platform/ydb#25589
closes #2010
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 47.39 MB | Main: 47.15 MB
Diff: +0.25 MB (0.52%)
ℹ️ CI Information