Skip to content

fix: open cluster page in same tab #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raubzeug merged 1 commit into from
Dec 5, 2025
Merged

fix: open cluster page in same tab #3179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/containers/Clusters/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,7 @@ function ClusterName({row}: ClusterNameProps) {

return (
<div className={b('cluster-name')}>
<ExternalLink href={clusterPath} target={row.clusterDomain ? '_blank' : undefined}>
{row.title || row.name}
</ExternalLink>
<ExternalLink href={clusterPath}>{row.title || row.name}</ExternalLink>
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When row.clusterDomain is present, calculateClusterPath() returns an absolute URL pointing to a different domain (see line 30 in utils.ts where clusterDomain is passed as the domain parameter). Opening external cluster links in the same tab will navigate the user away from the current clusters page, potentially losing their context and requiring them to use browser back/forward buttons to return.

Consider:

  1. If this is intentional, verify that this behavior aligns with user expectations
  2. Alternatively, consider using InternalLink component for internal cluster navigation and keeping target="_blank" for external domains to prevent navigation away from the clusters page

Copilot uses AI. Check for mistakes.
</div>
);
}
Expand Down Expand Up @@ -353,11 +351,7 @@ function Versions({row}: VersionsProps) {
}
const clusterPath = calculateClusterPath(row, clusterTabsIds.versions);
return (
<ExternalLink
className={b('cluster-versions')}
href={clusterPath}
target={row.clusterDomain ? '_blank' : undefined}
>
<ExternalLink className={b('cluster-versions')} href={clusterPath}>
<VersionsBar preparedVersions={preparedVersions} />
</ExternalLink>
);
Expand Down