fix: correct static paths, put fonts in media folder for monaco icons #3193
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand (embedded): https://nda.ya.ru/t/32lYhr3U7PVvuv
Stand (EM): https://nda.ya.ru/t/EaZJDnQT7PVvrj
Internal PR: https://nda.ya.ru/t/goECJJDK7PVvqw
How to check: try to search something in Monaco (Query Editor), check icons
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.49 MB | Main: 62.48 MB
Diff: +2.38 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information
Greptile Overview
Greptile Summary
Fixed Monaco editor icon display by correcting the asset path configuration in the build setup. The change adjusts
assetPrefixfrom'.'to'auto'for proper path resolution and explicitly configures fonts to be placed in thestatic/mediafolder as expected by the YDB server.assetPrefix: '.'toassetPrefix: 'auto'to enable automatic path resolutionfont: 'static/media'todistPathconfiguration to match YDB server expectationsConfidence Score: 5/5
Important Files Changed
File Analysis
Sequence Diagram
sequenceDiagram participant Dev as Developer participant Build as Rsbuild participant Monaco as Monaco Editor participant YDB as YDB Server participant Browser as Browser Dev->>Build: Configure rsbuild.config.ts Note over Build: assetPrefix: 'auto'<br/>font: 'static/media' Dev->>Build: npm run build Build->>Build: Process assets Build->>Build: Place font files in static/media/ Build->>Build: Generate JS/CSS with auto paths Build->>YDB: Deploy build/ folder Note over YDB: Serves static files<br/>from /monitoring Browser->>YDB: Request index.html YDB->>Browser: Return index.html Browser->>YDB: Request Monaco editor JS YDB->>Browser: Return Monaco JS Monaco->>Browser: Initialize editor Monaco->>YDB: Request codicon fonts<br/>(from static/media/) YDB->>Monaco: Return font files Monaco->>Browser: Render icons correctly