Skip to content

Conversation

@artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Dec 9, 2025

Stand (embedded): https://nda.ya.ru/t/32lYhr3U7PVvuv
Stand (EM): https://nda.ya.ru/t/EaZJDnQT7PVvrj
Internal PR: https://nda.ya.ru/t/goECJJDK7PVvqw

How to check: try to search something in Monaco (Query Editor), check icons

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 375 0 1 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 62.49 MB | Main: 62.48 MB
Diff: +2.38 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Greptile Overview

Greptile Summary

Fixed Monaco editor icon display by correcting the asset path configuration in the build setup. The change adjusts assetPrefix from '.' to 'auto' for proper path resolution and explicitly configures fonts to be placed in the static/media folder as expected by the YDB server.

  • Changed assetPrefix: '.' to assetPrefix: 'auto' to enable automatic path resolution
  • Added font: 'static/media' to distPath configuration to match YDB server expectations
  • Added comment explaining the YDB server requirement for font placement

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are small, targeted configuration adjustments that fix a specific asset path issue. The modifications are well-documented with inline comments, align with the YDB server's static file serving expectations, and the CI tests pass successfully (375/378 passed, with only 1 flaky test unrelated to these changes)
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
rsbuild.config.ts 5/5 Changed assetPrefix from '.' to 'auto' and configured fonts to output to static/media folder for Monaco editor icon compatibility

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Build as Rsbuild
    participant Monaco as Monaco Editor
    participant YDB as YDB Server
    participant Browser as Browser

    Dev->>Build: Configure rsbuild.config.ts
    Note over Build: assetPrefix: 'auto'<br/>font: 'static/media'
    
    Dev->>Build: npm run build
    Build->>Build: Process assets
    Build->>Build: Place font files in static/media/
    Build->>Build: Generate JS/CSS with auto paths
    
    Build->>YDB: Deploy build/ folder
    Note over YDB: Serves static files<br/>from /monitoring
    
    Browser->>YDB: Request index.html
    YDB->>Browser: Return index.html
    
    Browser->>YDB: Request Monaco editor JS
    YDB->>Browser: Return Monaco JS
    
    Monaco->>Browser: Initialize editor
    Monaco->>YDB: Request codicon fonts<br/>(from static/media/)
    YDB->>Monaco: Return font files
    Monaco->>Browser: Render icons correctly
Loading

@artemmufazalov artemmufazalov marked this pull request as ready for review December 9, 2025 14:47
Copilot AI review requested due to automatic review settings December 9, 2025 14:47
@artemmufazalov artemmufazalov added this pull request to the merge queue Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes static asset path configuration to ensure Monaco Editor icons display correctly when the UI is served by the YDB server. The changes address font file location and asset prefix handling.

  • Modified assetPrefix from '.' (relative) to 'auto' for proper path resolution
  • Configured font files to output to static/media folder as expected by YDB server's static file serving

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Merged via the queue into main with commit 90e1b53 Dec 9, 2025
16 checks passed
@artemmufazalov artemmufazalov deleted the fix-icons-in-monaco branch December 9, 2025 14:52
@artemmufazalov artemmufazalov self-assigned this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants