Skip to content

fix: cpu and ram columns fallback #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raubzeug merged 1 commit into from
Dec 11, 2025
Merged

fix: cpu and ram columns fallback #3211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/components/nodesColumns/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,16 +236,12 @@ export function getCpuColumn<
sortAccessor: ({PoolStats = []}) => Math.max(...PoolStats.map(({Usage}) => Number(Usage))),
defaultOrder: DataTable.DESCENDING,
render: ({row}) => {
if (!row.PoolStats) {
return EMPTY_DATA_PLACEHOLDER;
}

let totalPoolUsage =
isNumeric(row.CoresUsed) && isNumeric(row.CoresTotal)
? row.CoresUsed / row.CoresTotal
: undefined;

if (totalPoolUsage === undefined) {
if (totalPoolUsage === undefined && row.PoolStats) {
let totalThreadsCount = 0;
totalPoolUsage = row.PoolStats.reduce((acc, pool) => {
totalThreadsCount += Number(pool.Threads);
Expand All @@ -259,9 +255,10 @@ export function getCpuColumn<
<CellWithPopover
placement={['top', 'bottom']}
fullWidth
disabled={!row.PoolStats}
content={
<DefinitionList responsive>
{row.PoolStats.map((pool) =>
{row.PoolStats?.map((pool) =>
Copy link
Collaborator

@astandrik astandrik Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we check row.PoolStats in upper code - looks like ? is redundant

Copy link
Collaborator

@astandrik astandrik Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mislooked - my bad

isNumeric(pool.Usage) ? (
<DefinitionList.Item key={pool.Name} name={pool.Name}>
{formatPool('Usage', pool.Usage).value}
Expand Down
Loading