Skip to content

fix: fix copy button not hidden after copy #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: fix copy button not hidden after copy #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97679b5
fix: fix copy button not hidden after copy
artemmufazalov May 22, 2024
8450962
fix: review
artemmufazalov May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/EntityStatus/EntityStatus.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,16 @@

&__clipboard-button {
display: flex;
visibility: hidden;
flex-shrink: 0;

margin-left: 8px;

opacity: 0;
color: var(--g-color-text-secondary);

&_visible {
visibility: visible;
&_visible,
&:focus-visible {
opacity: 1;
}
}

Expand Down
5 changes: 2 additions & 3 deletions src/containers/App/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,9 @@ body,
.data-table__row,
.ydb-virtual-table__row,
.ydb-tree-view__item {
&:hover,
&:focus-within {
&:hover {
Copy link
Contributor

@Raubzeug Raubzeug May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add focus-visible here, to make the button visible if iterating with keyboard.

Copy link
Member Author

@artemmufazalov artemmufazalov May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elements with visibility:hidden cannot be selected with tab, so it doesn't have any effect

Copy link
Contributor

@Raubzeug Raubzeug May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%! What do you think if we hide them with opacity=0?

Copy link
Member Author

@artemmufazalov artemmufazalov May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opacity=0 works just fine, updated PR

& .clipboard-button {
visibility: visible;
opacity: 1;
}
}
}
Expand Down