Skip to content

Conversation

@rekby
Copy link
Member

@rekby rekby commented Jun 10, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Temporary skip test for nightly YDB as workaround of: ydb-platform/ydb#19449

@github-actions
Copy link

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

CoordinationEvents: value changed from 137438953472 to 1099511627776
DatabaseSQLConnEvents: value changed from 536870912 to 4294967296
DatabaseSQLConnectorEvents: value changed from 268435456 to 2147483648
DatabaseSQLEvents: value changed from 4026531840 to 32212254720
DatabaseSQLStmtEvents: value changed from 2147483648 to 17179869184
DatabaseSQLTxEvents: value changed from 1073741824 to 8589934592
DiscoveryEvents: value changed from 8589934592 to 68719476736
RatelimiterEvents: value changed from 68719476736 to 549755813888
RetryEvents: value changed from 4294967296 to 34359738368
SchemeEvents: value changed from 17179869184 to 137438953472
ScriptingEvents: value changed from 34359738368 to 274877906944
TopicEvents: value changed from 263979008 to 2143027200
TopicWriterEvents: value changed from 234881024 to 1879048192
TopicWriterStreamEvents: value changed from 67108864 to 536870912
TopicWriterStreamGrpcMessageEvents: value changed from 134217728 to 1073741824
TopicWriterStreamLifeCycleEvents: value changed from 33554432 to 268435456

compatible changes

Topic.OnListenerClose: added
Topic.OnListenerError: added
Topic.OnListenerInit: added
Topic.OnListenerReceiveMessage: added
Topic.OnListenerRouteMessage: added
Topic.OnListenerSendDataRequest: added
Topic.OnListenerSplitMessage: added
Topic.OnListenerStart: added
Topic.OnListenerUnknownMessage: added
Topic.OnPartitionWorkerHandlerCall: added
Topic.OnPartitionWorkerProcessMessage: added
Topic.OnPartitionWorkerStart: added
Topic.OnPartitionWorkerStop: added
TopicListenerCloseDoneInfo: added
TopicListenerCloseStartInfo: added
TopicListenerErrorInfo: added
TopicListenerEvents: added
TopicListenerInitDoneInfo: added
TopicListenerInitStartInfo: added
TopicListenerPartitionEvents: added
TopicListenerReceiveMessageInfo: added
TopicListenerRouteMessageInfo: added
TopicListenerSendDataRequestInfo: added
TopicListenerSplitMessageInfo: added
TopicListenerStartInfo: added
TopicListenerStreamEvents: added
TopicListenerUnknownMessageInfo: added
TopicListenerWorkerEvents: added
TopicOnListenerClose: added
TopicOnListenerError: added
TopicOnListenerInit: added
TopicOnListenerReceiveMessage: added
TopicOnListenerRouteMessage: added
TopicOnListenerSendDataRequest: added
TopicOnListenerSplitMessage: added
TopicOnListenerStart: added
TopicOnListenerUnknownMessage: added
TopicOnPartitionWorkerHandlerCall: added
TopicOnPartitionWorkerProcessMessage: added
TopicOnPartitionWorkerStart: added
TopicOnPartitionWorkerStop: added
TopicPartitionWorkerHandlerCallDoneInfo: added
TopicPartitionWorkerHandlerCallStartInfo: added
TopicPartitionWorkerProcessMessageDoneInfo: added
TopicPartitionWorkerProcessMessageStartInfo: added
TopicPartitionWorkerStartInfo: added
TopicPartitionWorkerStopDoneInfo: added
TopicPartitionWorkerStopStartInfo: added

summary

Base version: v3.109.0 (master)
Cannot suggest a release version.
Incompatible changes were detected.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (9dc2525) to head (1e0dc83).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
- Coverage   71.27%   70.61%   -0.66%     
==========================================
  Files         383      385       +2     
  Lines       39370    40154     +784     
==========================================
+ Hits        28062    28356     +294     
- Misses      10172    10623     +451     
- Partials     1136     1175      +39     
Flag Coverage Δ
experiment 70.05% <ø> (-0.81%) ⬇️
go-1.21.x 68.80% <ø> (-0.64%) ⬇️
go-1.24.x 70.57% <ø> (-0.67%) ⬇️
integration 53.51% <ø> (-0.52%) ⬇️
macOS 40.29% <ø> (-0.22%) ⬇️
ubuntu 70.61% <ø> (-0.67%) ⬇️
unit 40.30% <ø> (-0.22%) ⬇️
windows 40.26% <ø> (-0.25%) ⬇️
ydb-24.4 52.61% <ø> (-0.54%) ⬇️
ydb-25.1 53.13% <ø> (-0.79%) ⬇️
ydb-latest 53.01% <ø> (-0.60%) ⬇️
ydb-nightly 70.05% <ø> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rekby rekby merged commit 03abd6f into master Jun 10, 2025
57 of 108 checks passed
@rekby rekby deleted the disable-broken-test branch June 10, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants