Skip to content

Conversation

@asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@github-actions
Copy link

github.com/ydb-platform/ydb-go-sdk/v3/query

compatible changes

ImplicitTxControl: added

summary

Inferred base version: v3.120.0
Suggested version: v3.121.0

Copy link
Member

@polRk polRk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно вернуть сам slo

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.75%. Comparing base (b0290dd) to head (f1ad4a3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
+ Coverage   72.65%   73.75%   +1.10%     
==========================================
  Files         392      392              
  Lines       34417    34470      +53     
==========================================
+ Hits        25006    25425     +419     
+ Misses       8276     7912     -364     
+ Partials     1135     1133       -2     
Flag Coverage Δ
experiment 73.00% <ø> (?)
go-1.21.x 72.59% <ø> (-0.02%) ⬇️
go-1.25.x 73.74% <ø> (+1.56%) ⬆️
integration 54.87% <ø> (-0.04%) ⬇️
macOS 47.24% <ø> (-0.02%) ⬇️
ubuntu 73.75% <ø> (+1.11%) ⬆️
unit 47.25% <ø> (-0.02%) ⬇️
windows 47.23% <ø> (-0.03%) ⬇️
ydb-24.4 54.11% <ø> (ø)
ydb-25.2 54.81% <ø> (-0.04%) ⬇️
ydb-latest 54.41% <ø> (-0.08%) ⬇️
ydb-nightly 73.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new GitHub Actions workflow to check for the presence of an "SLO" label on pull requests, while removing the previous comprehensive SLO testing workflow. The new workflow creates a status check that requires PRs to have the "SLO" label.

Key Changes

  • Removed the full SLO workflow that performed YDB SDK performance testing across multiple configurations
  • Added a lightweight label-checking workflow that validates the presence of an "SLO" label on PRs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
.github/workflows/slo.yml Removed the comprehensive SLO testing workflow that included building Docker images, running performance tests, and comparing baseline vs. current versions
.github/workflows/check-slo-label.yml Added new workflow to check for "SLO" label presence on PRs and set commit status accordingly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

asmyasnikov and others added 3 commits November 27, 2025 12:21
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Nov 27, 2025

@asmyasnikov I've opened a new pull request, #1958, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Nov 27, 2025

@asmyasnikov I've opened a new pull request, #1959, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits November 27, 2025 12:30
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: asmyasnikov <14202262+asmyasnikov@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Nov 27, 2025

@asmyasnikov I've opened a new pull request, #1962, to work on those changes. Once the pull request is ready, I'll request review from you.

@asmyasnikov asmyasnikov merged commit 3b9920c into master Nov 27, 2025
39 checks passed
@asmyasnikov asmyasnikov deleted the check-slo-label branch November 27, 2025 10:05
@github-actions
Copy link

🌋 SLO Test Results

Status: ⚪ 6 workloads tested • All clear

Workload Metrics Regressions Improvements Links
native-bulk-upsert 8 0 0 ReportCheck
native-query 8 0 0 ReportCheck
native-table-over-query-service 8 0 0 ReportCheck
database-sql-query 8 0 0 ReportCheck
database-sql-table 8 0 0 ReportCheck
native-table 8 0 0 ReportCheck

Generated by ydb-slo-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants