-
Notifications
You must be signed in to change notification settings - Fork 108
Added check SLO label workflow #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
github.com/ydb-platform/ydb-go-sdk/v3/querycompatible changesImplicitTxControl: added summaryInferred base version: v3.120.0 |
polRk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно вернуть сам slo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
+ Coverage 72.65% 73.75% +1.10%
==========================================
Files 392 392
Lines 34417 34470 +53
==========================================
+ Hits 25006 25425 +419
+ Misses 8276 7912 -364
+ Partials 1135 1133 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new GitHub Actions workflow to check for the presence of an "SLO" label on pull requests, while removing the previous comprehensive SLO testing workflow. The new workflow creates a status check that requires PRs to have the "SLO" label.
Key Changes
- Removed the full SLO workflow that performed YDB SDK performance testing across multiple configurations
- Added a lightweight label-checking workflow that validates the presence of an "SLO" label on PRs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/slo.yml |
Removed the comprehensive SLO testing workflow that included building Docker images, running performance tests, and comparing baseline vs. current versions |
.github/workflows/check-slo-label.yml |
Added new workflow to check for "SLO" label presence on PRs and set commit status accordingly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c6cde97 to
547a1ec
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@asmyasnikov I've opened a new pull request, #1958, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@asmyasnikov I've opened a new pull request, #1959, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asmyasnikov <14202262+asmyasnikov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@asmyasnikov I've opened a new pull request, #1962, to work on those changes. Once the pull request is ready, I'll request review from you. |
🌋 SLO Test ResultsStatus: ⚪ 6 workloads tested • All clear
Generated by ydb-slo-action |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information