Skip to content

#350: Improve logging practices in BaseGrpcTransport and GrpcChannel #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

#350: Improve logging practices in BaseGrpcTransport and GrpcChannel #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/src/main/java/tech/ydb/core/impl/BaseGrpcTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ public <ReqT, RespT> CompletableFuture<Result<RespT>> unaryCall(

return new UnaryCall<>(traceId, call, handler).startCall(request, makeMetadataFromSettings(settings));
} catch (UnexpectedResultException ex) {
logger.error("UnaryCall[{}] got unexprected status {}", traceId, ex.getStatus());
logger.warn("UnaryCall[{}] got unexprected status {}", traceId, ex.getStatus());
return CompletableFuture.completedFuture(Result.fail(ex));
} catch (RuntimeException ex) {
logger.error("UnaryCall[{}] got problem {}", traceId, ex.getMessage());
logger.warn("UnaryCall[{}] got problem {}", traceId, ex.getMessage());
return CompletableFuture.completedFuture(Result.error(ex.getMessage(), ex));
}
}
Expand Down Expand Up @@ -133,10 +133,10 @@ public <ReqT, RespT> GrpcReadStream<RespT> readStreamCall(

return new ReadStreamCall<>(traceId, call, request, makeMetadataFromSettings(settings), handler);
} catch (UnexpectedResultException ex) {
logger.error("ReadStreamCall[{}] got unexpected status {}", traceId, ex.getStatus());
logger.warn("ReadStreamCall[{}] got unexpected status {}", traceId, ex.getStatus());
return new EmptyStream<>(ex.getStatus());
} catch (RuntimeException ex) {
logger.error("ReadStreamCall[{}] got problem {}", traceId, ex.getMessage());
logger.warn("ReadStreamCall[{}] got problem {}", traceId, ex.getMessage());
Issue issue = Issue.of(ex.getMessage(), Issue.Severity.ERROR);
return new EmptyStream<>(Status.of(StatusCode.CLIENT_INTERNAL_ERROR, issue));
}
Expand Down Expand Up @@ -177,10 +177,10 @@ public <ReqT, RespT> GrpcReadWriteStream<RespT, ReqT> readWriteStreamCall(
traceId, call, makeMetadataFromSettings(settings), getAuthCallOptions(), handler
);
} catch (UnexpectedResultException ex) {
logger.error("ReadWriteStreamCall[{}] got unexpected status {}", traceId, ex.getStatus());
logger.warn("ReadWriteStreamCall[{}] got unexpected status {}", traceId, ex.getStatus());
return new EmptyStream<>(ex.getStatus());
} catch (RuntimeException ex) {
logger.error("ReadWriteStreamCall[{}] got problem {}", traceId, ex.getMessage());
logger.warn("ReadWriteStreamCall[{}] got problem {}", traceId, ex.getMessage());
Issue issue = Issue.of(ex.getMessage(), Issue.Severity.ERROR);
return new EmptyStream<>(Status.of(StatusCode.CLIENT_INTERNAL_ERROR, issue));
}
Expand Down
7 changes: 3 additions & 4 deletions core/src/main/java/tech/ydb/core/impl/pool/GrpcChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ public GrpcChannel(EndpointRecord endpoint, ManagedChannelFactory factory) {
this.readyWatcher = new ReadyWatcher();
this.readyWatcher.checkState();
} catch (Throwable th) {
logger.error("cannot create channel", th);
throw new RuntimeException("cannot create channel", th);
}
}
Expand Down Expand Up @@ -80,13 +79,13 @@ public Channel getReadyChannel() {
try {
return future.get(connectTimeoutMs, TimeUnit.MILLISECONDS);
} catch (InterruptedException ex) {
logger.error("Grpc channel {} ready waiting is interrupted: ", endpoint, ex);
logger.warn("Grpc channel {} ready waiting is interrupted: ", endpoint, ex);
Thread.currentThread().interrupt();
} catch (ExecutionException ex) {
logger.error("Grpc channel {} connecting problem: ", endpoint, ex);
logger.warn("Grpc channel {} connecting problem: ", endpoint, ex);
throw new RuntimeException("Channel " + endpoint + " connecting problem", ex);
} catch (TimeoutException ex) {
logger.error("Grpc channel {} connect timeout exceeded", endpoint);
logger.warn("Grpc channel {} connect timeout exceeded", endpoint);
throw new RuntimeException("Channel " + endpoint + " connecting timeout");
}
return null;
Expand Down
Loading