Coordination: added timeout for session init waiting#653
Merged
alex268 merged 4 commits intoMay 27, 2026
Conversation
When a coordination session loses its gRPC stream and starts reconnecting, a new Stream is created with disableDeadline(). If the underlying TCP connection enters a half-open state (SYN established but no data flows), the gRPC stream never delivers SessionStarted, so startFuture never completes. The reconnect loop then stalls indefinitely, leaving all pending CompletableFutures (e.g. acquireEphemeralSemaphore) unresolved even after the application-level acquire timeout has expired. Fix: pass connectTimeout into Stream and schedule a one-shot timer that cancels the gRPC stream and completes startFuture with TIMEOUT if SessionStarted is not received within that window. The timer fires only when startFuture is still pending, so it is a no-op on the happy path. Reported via YDB support: YDBREQUESTS-7830
…store tests Keep Stream(Rpc rpc) as a delegate to Stream(rpc, Duration.ofSeconds(5)) so existing unit tests compile unchanged. SessionImpl passes the configured connectTimeout explicitly; the no-arg overload is only used in tests. Restore StreamTest.java (was accidentally cleared) and revert StreamIntegrationTest.java to the original constructor call.
alex268
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
============================================
+ Coverage 71.31% 71.44% +0.12%
- Complexity 3365 3373 +8
============================================
Files 379 379
Lines 15920 15929 +9
Branches 1669 1670 +1
============================================
+ Hits 11353 11380 +27
+ Misses 3917 3900 -17
+ Partials 650 649 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![robot-vibe-db[bot]](https://avatars.githubusercontent.com/in/3319454?s=60&v=4){kind=small}
AI Review SummaryVerdict: ✅ No critical issues found Critical issuesNo critical issues found. Other findings
This review was generated automatically. Critical issues require attention; other findings are advisory. |
|
Analysis performed by claude, claude-opus-4-6. |
There was a problem hiding this comment.
AI Review Summary
Verdict: ✅ No critical issues found
Critical issues
No critical issues found.
Other findings
- Minor | Medium:
cancelStream()short-circuit||leavesstopFutureuncompleted when the start-timeout fires, creating a brief window wherestop()could send on a cancelled stream —Stream.java:73 - Minor | Medium:
sendSessionStart()does not guard against a pre-completedstartFuture, so calling it aftercloseStream()sends on a half-closed gRPC stream —Stream.java:93 - Nit | High: Typo in test comment
STREAM_CANCEL_TIMOUT_MS→STREAM_CANCEL_TIMEOUT_MS—StreamTest.java:154
This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
|
Analysis performed by claude, claude-opus-4-6. |
alex268
force-pushed
the
feature/coordination-reconnect-timeout
branch
from
f644bf9 to
7c5ff79
Compare
KirillKurdyukov
approved these changes
May 27, 2026
AI Review SummaryVerdict: ✅ No critical issues found Critical issuesNo critical issues found. Other findings
This review was generated automatically. Critical issues require attention; other findings are advisory. |
|
Analysis performed by claude, claude-opus-4-6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.