Pass self and parent versions to sdk header#32
Merged
Conversation
vgvoleg
force-pushed
the
additional_info_sdk_headers
branch
2 times, most recently
from
70436ba to
543094b
Compare
There was a problem hiding this comment.
Pull request overview
Adds YDB SDK build-info header support so the client can always include the ydb-dbapi/<version> identifier and allow parent frameworks (e.g., SQLAlchemy) to append their own identifiers, addressing Issue #31.
Changes:
- Inject
ydb-dbapi/<VERSION>into YDB SDK_additional_sdk_headerswhen creating aydb.DriverConfig. - Allow passing extra
_additional_sdk_headersvia DBAPI connection kwargs to extend the header. - Bump the declared
ydbdependency version inpyproject.toml.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
ydb_dbapi/connections.py |
Builds and passes _additional_sdk_headers containing ydb-dbapi/<VERSION> (+ optional extras) into ydb.DriverConfig; updates kwargs typing. |
pyproject.toml |
Updates the ydb dependency constraint to a newer version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vgvoleg
force-pushed
the
additional_info_sdk_headers
branch
from
543094b to
c86993c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31