Skip to content

fix keep_in_cache flag alg #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix keep_in_cache flag alg #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ydb/_tx_ctx_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def _construct_tx_settings(tx_state):
def execute_request_factory(session_state, tx_state, query, parameters, commit_tx, settings):
data_query, query_id = session_state.lookup(query)
parameters_types = {}
keep_in_cache = False

if query_id is not None:
query_pb = _apis.ydb_table.Query(id=query_id)
parameters_types = data_query.parameters_types
Expand All @@ -119,20 +119,26 @@ def execute_request_factory(session_state, tx_state, query, parameters, commit_t
yql_text = data_query.yql_text
parameters_types = data_query.parameters_types
elif isinstance(query, types.DataQuery):
if settings is not None and hasattr(settings, "keep_in_cache"):
keep_in_cache = settings.keep_in_cache
else:
# that is an instance of a data query and we don't know query id for id.
# so let's prepare it to keep in cache
keep_in_cache = True
yql_text = query.yql_text
parameters_types = query.parameters_types
else:
yql_text = query
query_pb = _apis.ydb_table.Query(yql_text=yql_text)
request = _apis.ydb_table.ExecuteDataQueryRequest(parameters=convert.parameters_to_pb(parameters_types, parameters))

if query_id is not None:
# SDK not send query text and nothing save to cache
keep_in_cache = False
elif settings is not None and hasattr(settings, "keep_in_cache"):
keep_in_cache = settings.keep_in_cache
elif parameters:
keep_in_cache = True
else:
keep_in_cache = False

if keep_in_cache:
request.query_cache_policy.keep_in_cache = True

request.query.MergeFrom(query_pb)
tx_control = _apis.ydb_table.TransactionControl()
tx_control.commit_tx = commit_tx
Expand Down