Skip to content

fix execute text query with params #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023
Merged

fix execute text query with params #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832d53c
fix execute text query with params
rekby Apr 14, 2023
c38dc49
linter
rekby Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/table/table_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,13 @@ def create_table(session: ydb.Session):

res = driver_sync.scheme_client.describe_path(table_path)
assert res.type == ydb.scheme.SchemeEntryType.TABLE

def test_select_text_query_with_params(self, driver_sync):
def select(session: ydb.Session):
text_query = "DECLARE $v AS Int64; SELECT $v"
session.prepare(text_query)
with session.transaction() as tx:
tx.execute(text_query, {"$v": 1})

pool = ydb.SessionPool(driver=driver_sync)
pool.retry_operation_sync(select)
2 changes: 0 additions & 2 deletions ydb/_tx_ctx_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,5 @@ def wrap_result_and_tx_id(rpc_state, response_pb, session_state, tx_state, query
issues._process_response(response_pb.operation)
message = _apis.ydb_table.ExecuteQueryResult()
response_pb.operation.result.Unpack(message)
if message.query_meta.id:
session_state.keep(query, message.query_meta.id)
tx_state.tx_id = None if not message.tx_meta.id else message.tx_meta.id
return convert.ResultSets(message.result_sets, session_state.table_client_settings)