Fix hang while write messages to closed driver. #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valeria1235
suggested changes
May 18, 2023
ydb/topic.py
Outdated
| encoder_executor: Optional[concurrent.futures.Executor] = None, # default shared client executor pool | ||
| ) -> TopicWriter: | ||
| args = locals() | ||
| args = locals().copy() |
Member
Author
There was a problem hiding this comment.
because locals() return dynamic dict with infinite recursive field "args" and I can't remove it at next line without get own copy of dict.
| self.close() | ||
| except ydb.Error: | ||
| if exc_val: | ||
| raise exc_val |
Contributor
There was a problem hiding this comment.
maybe raise exc_val from e for keep full context?
Member
Author
There was a problem hiding this comment.
exc_val may contain some context alredy.
In this line I want preserve old exception if it exist.
exc_val from e will write about e if cause of excl_val and it will difficult to debug.
But the code don't need re-raise exc_val exception at all, i have fixed it, thanks.
Valeria1235
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #296
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information