add type hints for issues.py and types.py #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
reviewed
Sep 14, 2023
Member
rekby
left a comment
rekby
left a comment
There was a problem hiding this comment.
Great!
Thanks for your work. I have only cosmetic suggestions.
rekby
reviewed
Sep 15, 2023
ydb/issues.py
Outdated
| def __init__( | ||
| self, | ||
| message: str, | ||
| issues: typing.Optional[typing.Interable[_IssueMessage]] = None |
rekby
approved these changes
Oct 17, 2023
Member
|
@RaileyHartheim, thanks for the work. Type hints is great for understand relations in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information