Fix false cache hit #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
ydb.DataQueryis cached within a session scope using a hash of sql text as key. This lead to issues if a query is executed with different types (optional/required). For example, this code snipped reproduces the error:The "text" parameter in the first execution has type
Utf8andOptional<Utf8>in the second, which leads to error.Proposal
There is an ability to construct a cache key manually on the caller side, so it is possible to include types of parameters to it.
Result
The example query is executed without an error.