feat(TreeView): remove react-treeview package to avoid using native addEventListener
#64
Conversation
| let arrowClassName = 'tree-view_arrow'; | ||
| let containerClassName = 'tree-view_children'; | ||
| if (collapsed) { | ||
| arrowClassName += ' tree-view_arrow-collapsed'; | ||
| containerClassName += ' tree-view_children-collapsed'; | ||
| } |
There was a problem hiding this comment.
Left as it was to avoid rewriting selectors in styles.
There was a problem hiding this comment.
Probably, it will be better to add additional block('tree-view') and set this styles with this block: className={treeViewBlock('arrow', {collapsed})} . With comment, that it was done not to override selectors
There was a problem hiding this comment.
As I see, block uses __ as separator for elements and react-treeview uses _. I can use block like treeViewBlock({arrow: true, 'arrow-collapsed': collapsed}) but it seems confusing.
I suggest just comment on what is happening with these classNames.
There was a problem hiding this comment.
I see. Well, in this case, you could just comment, probably mentioning use cases, if someone further will want to update it:
There was a problem hiding this comment.
Done! Also rewrote TreeView`s own selectors to BEM notation.
… `addEventListener`
vovaspace
force-pushed
the
react-treeview-removal
branch
from
7e7f5b4 to
e910cad
Compare
2 participants
No description provided.