Skip to content

Fix some ubsan issues related to double vs ui64 #13364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix some ubsan issues related to double vs ui64 #13364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/sys_view/service/ext_counters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class TExtCountersUpdaterActor
ExecuteLatencyMsPrevValues[n] = value;
if (ExecuteLatencyMsBounds[n] == 0) {
NMonitoring::TBucketBound bound = snapshot->UpperBound(n);
ExecuteLatencyMsBounds[n] = bound == Max<NMonitoring::TBucketBound>() ? Max<ui64>() : bound;
ExecuteLatencyMsBounds[n] = bound == Max<NMonitoring::TBucketBound>() ? Max<ui64>() : ui64(bound);
}
}
metrics->AddMetric("queries.requests", total);
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/tablet_flat/ut/ut_stat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ Y_UNIT_TEST_SUITE(BuildStatsHistogram) {

ui32 operator()(const TRow&) noexcept
{
auto x = Random.Uniform(1 << Buckets);
auto x = Random.Uniform(1, 1 << Buckets);
return Min(ui32(log2(x)), Buckets - 1);
}

Expand Down
Loading