YQ-4188 Refactoring to reduce memory in Topic session #17354
Conversation
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| return NextMessageOffset; | ||
| } | ||
|
|
||
| TVector<TSchemaColumn> GetColumns() const override { |
There was a problem hiding this comment.
Возможно, const TVector & вместо TVector?
(... но надо ещё править IClientDataConsumer)
| const bool EnabledLLVM; | ||
| const ui64 StartingMessageTimestampMs; | ||
| const TString Predicate; | ||
| TVector<TSchemaColumn> Columns; |
There was a problem hiding this comment.
Его тоже можно сделать const, но придётся попрыгать с инициализацией (лябмдой или хелпером)
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/fq/libs/row_dispatcher/format_handler/format_handler.h
Outdated
Show resolved
Hide resolved
ydb/core/fq/libs/row_dispatcher/format_handler/ut/format_handler_ut.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: yumkam <yumkam@gmail.com>
Co-authored-by: yumkam <yumkam@gmail.com>
…er_ut.cpp Co-authored-by: yumkam <yumkam@gmail.com>
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…7354) Co-authored-by: yumkam <yumkam@gmail.com>
…7354) Co-authored-by: yumkam <yumkam@gmail.com>
2 participants
Changelog entry
...
Changelog category
Description for reviewers
...