Skip to content

[KQP RBO] Add simple predicate push down for left join on right side #19354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelvelikhov merged 1 commit into from
Jul 1, 2025
Merged

[KQP RBO] Add simple predicate push down for left join on right side #19354

pavelvelikhov merged 1 commit into from
Jul 1, 2025

Conversation

@denis0x0D
Copy link
Collaborator

@denis0x0D denis0x0D commented Jun 5, 2025 •
edited by pavelvelikhov
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

#19801

@denis0x0D denis0x0D requested a review from a team as a code owner June 5, 2025 11:27
@github-actions
Copy link

github-actions bot commented Jun 5, 2025 •
edited
Loading

⚪ 2025-06-05 11:30:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 035ff0c has started.
⚪ 2025-06-05 11:30:19 UTC Artifacts will be uploaded here
⚪ 2025-06-05 11:33:13 UTC ya make is running...
⚫ 2025-06-05 11:35:23 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jun 5, 2025 •
edited
Loading

🟢 2025-06-18 11:26:14 UTC The validation of the Pull Request description is successful.

@denis0x0D denis0x0D force-pushed the rbo_left_join_push branch from 64f05c8 to c0a7a6a Compare June 5, 2025 11:34
@github-actions
Copy link

github-actions bot commented Jun 5, 2025 •
edited
Loading

⚪ 2025-06-05 11:37:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 59f5182 has started.
⚪ 2025-06-05 11:37:44 UTC Artifacts will be uploaded here
⚪ 2025-06-05 11:40:49 UTC ya make is running...
🟡 2025-06-05 12:39:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21420 20044 0 3 1341 32

⚪ 2025-06-05 12:41:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-05 12:53:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
739 (only retried tests) 718 0 0 0 21

🟢 2025-06-05 12:53:58 UTC Build successful.
🟡 2025-06-05 12:54:19 UTC ydbd size 2.2 GiB changed* by +260.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9016403 merge: 59f5182 diff diff %
ydbd size 2 366 155 824 Bytes 2 366 422 560 Bytes +260.5 KiB +0.011%
ydbd stripped size 496 651 752 Bytes 496 687 496 Bytes +34.9 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 5, 2025 •
edited
Loading

⚪ 2025-06-05 11:47:50 UTC Pre-commit check linux-x86_64-release-asan for 59f5182 has started.
⚪ 2025-06-05 11:48:01 UTC Artifacts will be uploaded here
⚪ 2025-06-05 11:50:57 UTC ya make is running...
🟡 2025-06-05 13:26:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13653 13466 0 79 84 24

⚪ 2025-06-05 13:27:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-05 14:02:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1460 (only retried tests) 1382 0 48 10 20

⚪ 2025-06-05 14:02:48 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-05 14:37:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1346 (only retried tests) 1271 0 48 9 18

🟢 2025-06-05 14:37:40 UTC Build successful.
🟡 2025-06-05 14:38:14 UTC ydbd size 3.9 GiB changed* by +522.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9016403 merge: 59f5182 diff diff %
ydbd size 4 161 378 688 Bytes 4 161 913 472 Bytes +522.2 KiB +0.013%
ydbd stripped size 1 444 032 440 Bytes 1 444 160 888 Bytes +125.4 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@denis0x0D denis0x0D requested a review from pavelvelikhov June 5, 2025 11:59
pavelvelikhov
pavelvelikhov reviewed Jun 18, 2025
View reviewed changes
ydb/core/kqp/opt/rbo/kqp_rbo_rules.cpp
YQL_CLOG(TRACE, CoreDq) << "Wrong join type";
if (join->JoinKind != "Inner" && join->JoinKind != "Cross" && to_lower(join->JoinKind) != "left") {
YQL_CLOG(TRACE, CoreDq) << "Wrong join type " << join->JoinKind << Endl;
return input;
Copy link
Collaborator

@pavelvelikhov pavelvelikhov Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот это все безобразие с to_lower очень не нравится - давай сегодня обсудим на встрече? Я бы вообще Enum ввел, но YQL просили так не делать, если хотим чтобы они в какой-либо перспективе взяли себе в upstream

@pavelvelikhov pavelvelikhov merged commit cdae802 into ydb-platform:main Jul 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelvelikhov pavelvelikhov pavelvelikhov approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denis0x0D @pavelvelikhov