Skip to content

Conversation

@alexv-smirnov
Copy link
Member

PR was created by rightlib sync workflow run

robot-piglet and others added 12 commits June 7, 2025 08:51
commit_hash:929b636025dc9f709f1ff57bfa609d3504adba19
Засовываю `contrib/libs/brotli` под yamaker, чтобы была возможность обновлять его автоматически
commit_hash:4a75d7b2dc04c21ae4d9619af457fea1e6adbf8b
commit_hash:018a8aa49dc28afc356e3e6938826f660acd07ed
commit_hash:cc795ef3022ab137db4e9ee8d731f354c2d608ff
This pull request refactors the RPC client creation process to enhance clarity and flexibility.

The previous method of specifying the Unix domain socket path directly in
```
CreateRpcClient(
	"socketPath",
	TCreateClientOptions()
    	.UseProxyUnixDomainSocket(true)
        .MultiproxyTargetCluster("clusterName"));
```

has been changed to

```
CreateRpcClient(
    "clusterName",
    TCreateClientOptions()
    	.JobUnixDomainSocketPath("socketPath"));
```

Also fixes a minor bug, when serverName was set to socket path instead of cluster name.
commit_hash:d2e19d713304fd99c864377203642cff7a4652e7
commit_hash:cd50261c43b760159ad24f689964e656d0b76404
commit_hash:bd5f4cb87add017a4d96e29e55b014f905825898
commit_hash:fa53360347974a1c0f3badfe05ea1569a4b6212e
…parison operators.

The C++ standard describes the requirements for comparing unordered containers in [unord.req.general]:
> Two unordered containers a and b compare equal if a.size() == b.size() and,
> for every equivalent-key group [Ea1, Ea2) obtained from a.equal_range(Ea1),
> there exists an equivalent-key group [Eb1, Eb2) obtained from b.equal_range(Ea1),
> such that is_permutation(Ea1, Ea2, Eb1, Eb2) returns true.

THashSet should use the same comparison logic.
commit_hash:b897cd7387d275324bb22268d0be79da4e74bf16
commit_hash:0f93cb565a5faa95e824a7ffb27f7e396562a4d5
@alexv-smirnov alexv-smirnov requested a review from a team as a code owner June 8, 2025 00:52
@github-actions
Copy link

github-actions bot commented Jun 8, 2025

🟢 2025-06-08 00:55:11 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jun 8, 2025

2025-06-08 00:55:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 14ba201 has started.
2025-06-08 00:56:07 UTC Artifacts will be uploaded here
2025-06-08 01:01:39 UTC ya make is running...
🟡 2025-06-08 03:14:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
33024 30330 0 3 2658 33

2025-06-08 03:17:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-08 03:32:06 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
764 (only retried tests) 734 0 0 1 29

🟢 2025-06-08 03:32:18 UTC Build successful.
🟢 2025-06-08 03:32:39 UTC ydbd size 2.2 GiB changed* by +15.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 81ee194 merge: 14ba201 diff diff %
ydbd size 2 370 255 968 Bytes 2 370 271 976 Bytes +15.6 KiB +0.001%
ydbd stripped size 497 246 120 Bytes 497 246 568 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 8, 2025

2025-06-08 00:55:58 UTC Pre-commit check linux-x86_64-release-asan for 14ba201 has started.
2025-06-08 00:56:09 UTC Artifacts will be uploaded here
2025-06-08 01:01:41 UTC ya make is running...
🟡 2025-06-08 03:49:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17688 17418 0 129 116 25

2025-06-08 03:51:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-08 04:27:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1668 (only retried tests) 1513 0 72 61 22

2025-06-08 04:27:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-08 05:00:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1534 (only retried tests) 1435 0 75 5 19

🟢 2025-06-08 05:01:02 UTC Build successful.
🟢 2025-06-08 05:01:36 UTC ydbd size 3.9 GiB changed* by +64.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 81ee194 merge: 14ba201 diff diff %
ydbd size 4 168 711 992 Bytes 4 168 778 328 Bytes +64.8 KiB +0.002%
ydbd stripped size 1 446 052 920 Bytes 1 446 064 888 Bytes +11.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexv-smirnov alexv-smirnov merged commit 33732bf into main Jun 8, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants