Skip to content

Conversation

@mregrock
Copy link
Collaborator

Changelog entry

Fix example configs in deploy

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

🟢 2025-06-10 09:27:25 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jun 10, 2025

2025-06-10 09:29:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 10f87e5 has started.
2025-06-10 09:29:55 UTC Artifacts will be uploaded here
2025-06-10 09:32:26 UTC ya make is running...
🟢 2025-06-10 09:32:32 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-10 09:32:37 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jun 10, 2025

2025-06-10 09:30:03 UTC Pre-commit check linux-x86_64-release-asan for 10f87e5 has started.
2025-06-10 09:30:14 UTC Artifacts will be uploaded here
2025-06-10 09:32:40 UTC ya make is running...
🟢 2025-06-10 09:32:45 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-10 09:32:51 UTC Build successful.

@blinkov blinkov requested a review from Copilot June 10, 2025 09:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes example deployment configurations by removing the outdated table_service_config blocks from several YAML config examples.

  • Removed table_service_config blocks in single-node and mirror examples
  • Ensured consistent configuration examples that align with current deployment standards

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ydb/deploy/yaml_config_examples/single-node-with-file.yaml Removed table_service_config block
ydb/deploy/yaml_config_examples/single-node-in-memory.yaml Removed table_service_config block
ydb/deploy/yaml_config_examples/mirror-3dc-9-nodes.yaml Removed table_service_config block
ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes.yaml Removed table_service_config block
ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes-in-memory.yaml Removed table_service_config block
ydb/deploy/yaml_config_examples/block-4-2.yaml Removed table_service_config block(s)
Comments suppressed due to low confidence (6)

ydb/deploy/yaml_config_examples/single-node-with-file.yaml:24

  • The removal of the table_service_config block appears intentional; however, consider adding an inline comment explaining that its removal reflects the updated deployment configuration standards.
   -  table_service_config:

ydb/deploy/yaml_config_examples/single-node-in-memory.yaml:24

  • The table_service_config block has been removed consistently; consider adding a note in the example to clarify that this change aligns with current config practices.
   -  table_service_config:

ydb/deploy/yaml_config_examples/mirror-3dc-9-nodes.yaml:73

  • Ensure that the removal of the table_service_config block is documented (e.g., via an inline comment) so users understand that this property is deprecated in the updated configuration.
   -  table_service_config:

ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes.yaml:48

  • Consider adding a clarifying comment in this YAML example to indicate that the removal of table_service_config is intentional and part of the updated deployment config.
   -  table_service_config:

ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes-in-memory.yaml:42

  • The table_service_config block removal is consistent with other examples; an inline note explaining the change could improve clarity for users referencing the example.
   -  table_service_config:

ydb/deploy/yaml_config_examples/block-4-2.yaml:46

  • The removal of the table_service_config block (as indicated by the '-' line) is clear; consider adding a comment to document that this change aligns with the new deployment configuration standards.
   -

Copy link
Member

@blinkov blinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that further improvements will be in a separate PR.

@mregrock mregrock merged commit 0bc572e into ydb-platform:main Jun 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants