-
Notifications
You must be signed in to change notification settings - Fork 742
Fix example configs in deploy #19545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes example deployment configurations by removing the outdated table_service_config blocks from several YAML config examples.
- Removed table_service_config blocks in single-node and mirror examples
- Ensured consistent configuration examples that align with current deployment standards
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/deploy/yaml_config_examples/single-node-with-file.yaml | Removed table_service_config block |
| ydb/deploy/yaml_config_examples/single-node-in-memory.yaml | Removed table_service_config block |
| ydb/deploy/yaml_config_examples/mirror-3dc-9-nodes.yaml | Removed table_service_config block |
| ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes.yaml | Removed table_service_config block |
| ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes-in-memory.yaml | Removed table_service_config block |
| ydb/deploy/yaml_config_examples/block-4-2.yaml | Removed table_service_config block(s) |
Comments suppressed due to low confidence (6)
ydb/deploy/yaml_config_examples/single-node-with-file.yaml:24
- The removal of the table_service_config block appears intentional; however, consider adding an inline comment explaining that its removal reflects the updated deployment configuration standards.
- table_service_config:
ydb/deploy/yaml_config_examples/single-node-in-memory.yaml:24
- The table_service_config block has been removed consistently; consider adding a note in the example to clarify that this change aligns with current config practices.
- table_service_config:
ydb/deploy/yaml_config_examples/mirror-3dc-9-nodes.yaml:73
- Ensure that the removal of the table_service_config block is documented (e.g., via an inline comment) so users understand that this property is deprecated in the updated configuration.
- table_service_config:
ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes.yaml:48
- Consider adding a clarifying comment in this YAML example to indicate that the removal of table_service_config is intentional and part of the updated deployment config.
- table_service_config:
ydb/deploy/yaml_config_examples/mirror-3dc-3-nodes-in-memory.yaml:42
- The table_service_config block removal is consistent with other examples; an inline note explaining the change could improve clarity for users referencing the example.
- table_service_config:
ydb/deploy/yaml_config_examples/block-4-2.yaml:46
- The removal of the table_service_config block (as indicated by the '-' line) is clear; consider adding a comment to document that this change aligns with the new deployment configuration standards.
-
blinkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that further improvements will be in a separate PR.
Changelog entry
Fix example configs in deploy
Changelog category
Description for reviewers
...