Skip to content

Conversation

@buhtr
Copy link
Collaborator

@buhtr buhtr commented Jul 31, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

@buhtr buhtr requested a review from a team as a code owner July 31, 2025 15:10
@github-actions
Copy link

github-actions bot commented Jul 31, 2025

🟢 2025-08-31 10:07:45 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jul 31, 2025

2025-07-31 16:43:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 83419b5 has started.
2025-07-31 16:43:44 UTC Artifacts will be uploaded here
2025-07-31 16:47:01 UTC ya make is running...
🟡 2025-07-31 18:02:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37155 34331 0 50 2743 31

2025-07-31 18:05:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-31 18:17:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
327 (only retried tests) 203 0 49 50 25

2025-07-31 18:17:47 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-31 18:29:38 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
315 (only retried tests) 193 0 49 50 23

🟢 2025-07-31 18:29:49 UTC Build successful.
🟢 2025-07-31 18:30:11 UTC ydbd size 2.2 GiB changed* by -72.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: de7dd20 merge: 83419b5 diff diff %
ydbd size 2 407 303 096 Bytes 2 407 228 896 Bytes -72.5 KiB -0.003%
ydbd stripped size 503 008 712 Bytes 503 010 312 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 31, 2025

2025-07-31 16:44:39 UTC Pre-commit check linux-x86_64-release-asan for 83419b5 has started.
2025-07-31 16:45:00 UTC Artifacts will be uploaded here
2025-07-31 16:49:06 UTC ya make is running...
🟡 2025-07-31 18:33:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14672 14217 0 177 256 22

🟢 2025-07-31 18:35:03 UTC Build successful.
🟢 2025-07-31 18:35:31 UTC ydbd size 3.9 GiB changed* by -104.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: de7dd20 merge: 83419b5 diff diff %
ydbd size 4 232 675 080 Bytes 4 232 568 552 Bytes -104.0 KiB -0.003%
ydbd stripped size 1 466 077 688 Bytes 1 466 064 792 Bytes -12.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@buhtr buhtr force-pushed the feature/ext-list-split branch from f0d248f to 0da41df Compare August 1, 2025 18:23
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

2025-08-01 18:34:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for c7efff1 has started.
2025-08-01 18:35:08 UTC Artifacts will be uploaded here
2025-08-01 18:39:06 UTC ya make is running...
🟡 2025-08-01 19:52:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37178 34368 0 39 2743 28

2025-08-01 19:55:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-01 20:07:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
317 (only retried tests) 210 0 36 50 21

2025-08-01 20:08:04 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-08-01 20:19:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
293 (only retried tests) 189 0 36 50 18

🟢 2025-08-01 20:19:57 UTC Build successful.
🟡 2025-08-01 20:20:18 UTC ydbd size 2.2 GiB changed* by +182.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0c653e4 merge: c7efff1 diff diff %
ydbd size 2 409 987 880 Bytes 2 410 174 904 Bytes +182.6 KiB +0.008%
ydbd stripped size 503 403 624 Bytes 503 424 680 Bytes +20.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

2025-08-01 18:37:05 UTC Pre-commit check linux-x86_64-release-asan for c7efff1 has started.
2025-08-01 18:37:21 UTC Artifacts will be uploaded here
2025-08-01 18:40:51 UTC ya make is running...
🟡 2025-08-01 20:35:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14695 14195 0 164 312 24

🟢 2025-08-01 20:36:57 UTC Build successful.
🟡 2025-08-01 20:37:27 UTC ydbd size 3.9 GiB changed* by +361.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0c653e4 merge: c7efff1 diff diff %
ydbd size 4 236 981 848 Bytes 4 237 351 808 Bytes +361.3 KiB +0.009%
ydbd stripped size 1 467 135 672 Bytes 1 467 208 312 Bytes +70.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from Copilot August 4, 2025 17:34

This comment was marked as resolved.

@buhtr buhtr force-pushed the feature/ext-list-split branch from 0da41df to a43509c Compare August 18, 2025 10:35
@github-actions
Copy link

github-actions bot commented Aug 18, 2025

2025-08-18 10:36:43 UTC Pre-commit check linux-x86_64-release-asan for 28e238b has started.
2025-08-18 10:36:47 UTC Artifacts will be uploaded here
2025-08-18 10:40:04 UTC ya make is running...
🟡 2025-08-18 12:29:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14915 14502 0 102 290 21

🟢 2025-08-18 12:31:14 UTC Build successful.
🟡 2025-08-18 12:31:42 UTC ydbd size 4.0 GiB changed* by +361.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1dcbe4b merge: 28e238b diff diff %
ydbd size 4 268 487 984 Bytes 4 268 857 920 Bytes +361.3 KiB +0.009%
ydbd stripped size 1 481 219 736 Bytes 1 481 295 672 Bytes +74.2 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

2025-08-18 10:36:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 28e238b has started.
2025-08-18 10:36:51 UTC Artifacts will be uploaded here
2025-08-18 10:40:10 UTC ya make is running...
🟡 2025-08-18 11:57:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37506 34744 0 5 2717 40

2025-08-18 12:00:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-18 12:14:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
396 (only retried tests) 359 0 0 9 28

🟢 2025-08-18 12:14:37 UTC Build successful.
🟡 2025-08-18 12:14:57 UTC ydbd size 2.3 GiB changed* by +176.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1dcbe4b merge: 28e238b diff diff %
ydbd size 2 428 302 584 Bytes 2 428 482 784 Bytes +176.0 KiB +0.007%
ydbd stripped size 509 057 640 Bytes 509 075 496 Bytes +17.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

2025-08-19 16:05:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 07e1702 has started.
2025-08-19 16:05:37 UTC Artifacts will be uploaded here
2025-08-19 16:08:58 UTC ya make is running...
🟡 2025-08-19 17:28:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37546 34797 0 2 2710 37

2025-08-19 17:31:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-19 17:45:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
250 (only retried tests) 224 0 0 1 25

🟢 2025-08-19 17:45:24 UTC Build successful.
🟡 2025-08-19 17:45:44 UTC ydbd size 2.3 GiB changed* by +206.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 3141db5 merge: 07e1702 diff diff %
ydbd size 2 429 060 216 Bytes 2 429 271 264 Bytes +206.1 KiB +0.009%
ydbd stripped size 509 211 816 Bytes 509 228 328 Bytes +16.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

2025-08-19 16:05:46 UTC Pre-commit check linux-x86_64-release-asan for 07e1702 has started.
2025-08-19 16:06:26 UTC Artifacts will be uploaded here
2025-08-19 16:10:23 UTC ya make is running...
🟡 2025-08-19 18:03:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14950 14546 0 87 293 24

🟢 2025-08-19 18:04:22 UTC Build successful.
🟡 2025-08-19 18:04:49 UTC ydbd size 4.0 GiB changed* by +385.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6213f1a merge: 07e1702 diff diff %
ydbd size 4 269 801 136 Bytes 4 270 195 864 Bytes +385.5 KiB +0.009%
ydbd stripped size 1 481 693 976 Bytes 1 481 778 008 Bytes +82.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

2025-08-21 10:47:53 UTC Pre-commit check linux-x86_64-release-asan for 2c3e4ef has started.
2025-08-21 10:48:08 UTC Artifacts will be uploaded here
2025-08-21 10:51:30 UTC ya make is running...
🟡 2025-08-21 12:43:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14988 14517 0 161 288 22

🟢 2025-08-21 12:45:12 UTC Build successful.
🟡 2025-08-21 12:45:38 UTC ydbd size 4.0 GiB changed* by +515.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: acfc082 merge: 2c3e4ef diff diff %
ydbd size 4 268 775 568 Bytes 4 269 303 272 Bytes +515.3 KiB +0.012%
ydbd stripped size 1 481 373 272 Bytes 1 481 496 888 Bytes +120.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

2025-08-21 10:49:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2c3e4ef has started.
2025-08-21 10:49:17 UTC Artifacts will be uploaded here
2025-08-21 10:52:36 UTC ya make is running...
🟡 2025-08-21 12:07:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37586 34826 0 5 2723 32

2025-08-21 12:11:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-21 12:24:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
296 (only retried tests) 273 0 0 1 22

🟢 2025-08-21 12:24:30 UTC Build successful.
🟡 2025-08-21 12:24:49 UTC ydbd size 2.3 GiB changed* by +263.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: acfc082 merge: 2c3e4ef diff diff %
ydbd size 2 429 138 832 Bytes 2 429 408 560 Bytes +263.4 KiB +0.011%
ydbd stripped size 509 252 392 Bytes 509 297 896 Bytes +44.4 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

2025-08-21 14:06:49 UTC Pre-commit check linux-x86_64-release-asan for bfef8a9 has started.
2025-08-21 14:07:02 UTC Artifacts will be uploaded here
2025-08-21 14:10:19 UTC ya make is running...
🟡 2025-08-21 16:00:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14988 14576 0 104 280 28

🟢 2025-08-21 16:01:56 UTC Build successful.
🟡 2025-08-21 16:02:23 UTC ydbd size 4.0 GiB changed* by +526.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 88ec1e6 merge: bfef8a9 diff diff %
ydbd size 4 268 747 824 Bytes 4 269 286 608 Bytes +526.2 KiB +0.013%
ydbd stripped size 1 481 364 024 Bytes 1 481 494 168 Bytes +127.1 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 21, 2025

2025-08-21 14:08:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for bfef8a9 has started.
2025-08-21 14:08:51 UTC Artifacts will be uploaded here
2025-08-21 14:12:08 UTC ya make is running...
🟡 2025-08-21 15:27:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37586 34834 0 1 2716 35

2025-08-21 15:30:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-08-21 15:44:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
347 (only retried tests) 317 0 1 4 25

2025-08-21 15:44:17 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-08-21 15:57:54 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
231 (only retried tests) 204 0 1 1 25

🟢 2025-08-21 15:58:02 UTC Build successful.
🟡 2025-08-21 15:58:23 UTC ydbd size 2.3 GiB changed* by +263.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 88ec1e6 merge: bfef8a9 diff diff %
ydbd size 2 429 128 688 Bytes 2 429 398 136 Bytes +263.1 KiB +0.011%
ydbd stripped size 509 251 240 Bytes 509 293 544 Bytes +41.3 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@buhtr buhtr force-pushed the feature/ext-list-split branch from 95ae030 to 8b43008 Compare August 24, 2025 10:46
@github-actions
Copy link

github-actions bot commented Aug 24, 2025

2025-08-24 10:49:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 543c9b9 has started.
2025-08-24 10:50:09 UTC Artifacts will be uploaded here
2025-08-24 10:53:35 UTC ya make is running...
🟡 2025-08-24 12:10:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37689 34928 0 2 2719 40

2025-08-24 12:14:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-24 12:25:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
388 (only retried tests) 361 0 0 3 24

🟢 2025-08-24 12:26:00 UTC Build successful.
🟡 2025-08-24 12:26:19 UTC ydbd size 2.3 GiB changed* by +265.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9e528c5 merge: 543c9b9 diff diff %
ydbd size 2 431 636 544 Bytes 2 431 908 160 Bytes +265.2 KiB +0.011%
ydbd stripped size 509 480 264 Bytes 509 522 952 Bytes +41.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 24, 2025

2025-08-24 10:50:04 UTC Pre-commit check linux-x86_64-release-asan for 543c9b9 has started.
2025-08-24 10:50:18 UTC Artifacts will be uploaded here
2025-08-24 10:53:39 UTC ya make is running...
🟡 2025-08-24 12:47:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15065 14577 0 116 345 27

🟢 2025-08-24 12:48:54 UTC Build successful.
🟡 2025-08-24 12:49:22 UTC ydbd size 4.0 GiB changed* by +533.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9e528c5 merge: 543c9b9 diff diff %
ydbd size 4 273 237 512 Bytes 4 273 784 200 Bytes +533.9 KiB +0.013%
ydbd stripped size 1 482 240 376 Bytes 1 482 375 544 Bytes +132.0 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 07:16:44 UTC Pre-commit check linux-x86_64-release-asan for 8b53dc8 has started.
2025-08-27 07:16:59 UTC Artifacts will be uploaded here
2025-08-27 07:20:29 UTC ya make is running...
🟡 2025-08-27 09:30:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15137 14627 0 141 336 33

🟢 2025-08-27 09:32:17 UTC Build successful.
🟡 2025-08-27 09:32:48 UTC ydbd size 4.0 GiB changed* by +472.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 32a8062 merge: 8b53dc8 diff diff %
ydbd size 4 276 903 504 Bytes 4 277 387 376 Bytes +472.5 KiB +0.011%
ydbd stripped size 1 483 222 200 Bytes 1 483 337 592 Bytes +112.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

2025-08-27 07:17:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b53dc8 has started.
2025-08-27 07:17:55 UTC Artifacts will be uploaded here
2025-08-27 07:21:16 UTC ya make is running...
🟡 2025-08-27 08:45:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37766 34988 0 3 2733 42

2025-08-27 08:48:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-27 09:09:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
834 (only retried tests) 770 0 0 40 24

🟢 2025-08-27 09:09:56 UTC Build successful.
🟡 2025-08-27 09:10:18 UTC ydbd size 2.3 GiB changed* by +245.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 32a8062 merge: 8b53dc8 diff diff %
ydbd size 2 433 738 328 Bytes 2 433 990 112 Bytes +245.9 KiB +0.010%
ydbd stripped size 509 795 272 Bytes 509 833 864 Bytes +37.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Comment on lines 238 to 234
if (table.first->HasSplitsForSelect(select)) {
continue;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну уверен, что эта проверка тут нужна, если уже сплит полистили - значит на момент запуска листинга его не было, оптимизации однопоточные, по этому сплит не должен был появиться в DoApplyAsyncChanges

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Запрос может состоять из нескольких subquery или join-ов, которые с учетом реализованых pushdown-ов могут соответсвовать одному select-у, эта проверка скипает повторную отправку ListSplit если в текущем запросе для этого select-a уже получили сплиты.

@buhtr buhtr changed the title move listsplit after physical opt Move listsplit after physical opt Aug 31, 2025
pavelvelikhov
pavelvelikhov previously approved these changes Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

2025-10-10 16:15:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 26c8d9b has started.
2025-10-10 16:15:56 UTC Artifacts will be uploaded here
2025-10-10 16:19:37 UTC ya make is running...
🟡 2025-10-10 17:56:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38870 36087 0 2 2754 27

2025-10-10 17:56:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-10 18:12:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
545 (only retried tests) 518 0 1 1 25

2025-10-10 18:12:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-10 18:28:39 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
573 (only retried tests) 551 0 0 1 21

🟢 2025-10-10 18:28:42 UTC Build successful.
🟡 2025-10-10 18:29:01 UTC ydbd size 2.3 GiB changed* by +888.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a446a72 merge: 26c8d9b diff diff %
ydbd size 2 418 700 232 Bytes 2 419 610 456 Bytes +888.9 KiB +0.038%
ydbd stripped size 515 107 272 Bytes 515 330 792 Bytes +218.3 KiB +0.043%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

2025-10-10 16:23:45 UTC Pre-commit check linux-x86_64-release-asan for 26c8d9b has started.
2025-10-10 16:24:11 UTC Artifacts will be uploaded here
2025-10-10 16:28:17 UTC ya make is running...
🟡 2025-10-10 18:23:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15799 15408 0 155 215 21

🟢 2025-10-10 18:23:13 UTC Build successful.
🟡 2025-10-10 18:23:36 UTC ydbd size 3.7 GiB changed* by +716.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 21a2666 merge: 26c8d9b diff diff %
ydbd size 4 024 311 984 Bytes 4 025 045 880 Bytes +716.7 KiB +0.018%
ydbd stripped size 1 494 692 384 Bytes 1 495 005 312 Bytes +305.6 KiB +0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@buhtr buhtr merged commit b050143 into ydb-platform:main Oct 13, 2025
14 checks passed
buhtr added a commit to buhtr/ydb that referenced this pull request Oct 15, 2025

bool operator==(const TSelectKey& other) const = default;

TSelectKey& operator=(const TSelectKey& other) = default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

у тебя же поля константные

}

void TGenericState::TTableMeta::AttachSplitsForSelect(const TSelectKey& key, std::vector<NYql::NConnector::NApi::TSplit>& splits) {
Y_ENSURE(splits.size());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty()

std::transform(std::make_move_iterator(response.mutable_splits()->begin()),
std::make_move_iterator(response.mutable_splits()->end()),
std::back_inserter(desc->Splits),
[](auto&& split) { return std::move(split); });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

что за странная лямбда? что-то не то делаешь

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants