-
Notifications
You must be signed in to change notification settings - Fork 736
Move listsplit after physical opt #22085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
f0d248f to
0da41df
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/library/yql/providers/generic/provider/yql_generic_physical_opt.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_load_meta.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_describe.h
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_describe.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list.cpp
Outdated
Show resolved
Hide resolved
0da41df to
a43509c
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/library/yql/providers/generic/provider/yql_generic_describe_table.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_dq_integration.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list_splits.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list_splits.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list_splits.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_state.cpp
Outdated
Show resolved
Hide resolved
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
95ae030 to
8b43008
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/kqp/ut/federated_query/generic_ut/kqp_generic_provider_ut.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_utils.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_utils.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_utils.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list_splits.h
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list_splits.cpp
Outdated
Show resolved
Hide resolved
| if (table.first->HasSplitsForSelect(select)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну уверен, что эта проверка тут нужна, если уже сплит полистили - значит на момент запуска листинга его не было, оптимизации однопоточные, по этому сплит не должен был появиться в DoApplyAsyncChanges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Запрос может состоять из нескольких subquery или join-ов, которые с учетом реализованых pushdown-ов могут соответсвовать одному select-у, эта проверка скипает повторную отправку ListSplit если в текущем запросе для этого select-a уже получили сплиты.
ydb/library/yql/providers/generic/provider/yql_generic_describe_table.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_describe_table.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_predicate_pushdown.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_physical_opt.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_list_splits.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_describe_table.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/provider/yql_generic_describe_table.h
Outdated
Show resolved
Hide resolved
…former + TGenericListTransformer
f60dab4 to
3a29ccf
Compare
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| bool operator==(const TSelectKey& other) const = default; | ||
|
|
||
| TSelectKey& operator=(const TSelectKey& other) = default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
у тебя же поля константные
| } | ||
|
|
||
| void TGenericState::TTableMeta::AttachSplitsForSelect(const TSelectKey& key, std::vector<NYql::NConnector::NApi::TSplit>& splits) { | ||
| Y_ENSURE(splits.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty()
| std::transform(std::make_move_iterator(response.mutable_splits()->begin()), | ||
| std::make_move_iterator(response.mutable_splits()->end()), | ||
| std::back_inserter(desc->Splits), | ||
| [](auto&& split) { return std::move(split); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
что за странная лямбда? что-то не то делаешь
Changelog category