Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 10, 2025

Changelog entry

Correct FreeUpToLsn interpretation

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch fixes cases when FreeUpToLsn was misinterpreted as inclusive one.

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

2025-09-10 09:33:53 UTC Pre-commit check linux-x86_64-release-asan for f77bc94 has started.
2025-09-10 09:33:57 UTC Artifacts will be uploaded here
2025-09-10 09:37:27 UTC ya make is running...
🟡 2025-09-10 11:52:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15719 15246 0 178 270 25

🟢 2025-09-10 11:53:41 UTC Build successful.
🟡 2025-09-10 11:54:04 UTC ydbd size 4.0 GiB changed* by +113.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 747eb09 merge: f77bc94 diff diff %
ydbd size 4 312 200 248 Bytes 4 312 316 464 Bytes +113.5 KiB +0.003%
ydbd stripped size 1 491 570 296 Bytes 1 491 605 336 Bytes +34.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

2025-09-10 09:35:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for f77bc94 has started.
2025-09-10 09:35:28 UTC Artifacts will be uploaded here
2025-09-10 09:39:16 UTC ya make is running...
🟡 2025-09-10 11:09:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31380 29964 0 11 1370 35

2025-09-10 11:12:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-10 11:22:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
400 (only retried tests) 376 0 2 0 22

2025-09-10 11:22:51 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-09-10 11:29:56 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 197 0 2 0 19

🟢 2025-09-10 11:30:03 UTC Build successful.
🟢 2025-09-10 11:30:22 UTC ydbd size 2.3 GiB changed* by +79.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 747eb09 merge: f77bc94 diff diff %
ydbd size 2 465 086 184 Bytes 2 465 167 648 Bytes +79.6 KiB +0.003%
ydbd stripped size 515 205 672 Bytes 515 214 888 Bytes +9.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-09-10 10:04:15 UTC The validation of the Pull Request description is successful.

@alexvru alexvru added the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

2025-09-10 13:18:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for f944cc1 has started.
2025-09-10 13:18:24 UTC Artifacts will be uploaded here
2025-09-10 13:21:58 UTC ya make is running...
🟡 2025-09-10 14:40:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31407 29984 0 5 1376 42

2025-09-10 14:43:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-10 15:02:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
680 (only retried tests) 653 0 1 3 23

2025-09-10 15:03:00 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-09-10 15:16:01 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
221 (only retried tests) 198 0 1 0 22

🟢 2025-09-10 15:16:09 UTC Build successful.
🔴 2025-09-10 15:16:43 UTC ydbd size 2.3 GiB changed* by +3.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 747eb09 merge: f944cc1 diff diff %
ydbd size 2 465 086 184 Bytes 2 468 310 448 Bytes +3.1 MiB +0.131%
ydbd stripped size 515 205 672 Bytes 515 735 432 Bytes +517.3 KiB +0.103%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

2025-09-10 13:18:26 UTC Pre-commit check linux-x86_64-release-asan for f944cc1 has started.
2025-09-10 13:18:51 UTC Artifacts will be uploaded here
2025-09-10 13:22:29 UTC ya make is running...
🟡 2025-09-10 15:31:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15732 15204 0 172 329 27

🟢 2025-09-10 15:32:40 UTC Build successful.
🔴 2025-09-10 15:33:05 UTC ydbd size 4.0 GiB changed* by +5.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 747eb09 merge: f944cc1 diff diff %
ydbd size 4 312 200 248 Bytes 4 317 728 368 Bytes +5.3 MiB +0.128%
ydbd stripped size 1 491 570 296 Bytes 1 493 036 248 Bytes +1.4 MiB +0.098%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru added the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

2025-09-10 19:13:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c4f31a has started.
2025-09-10 19:13:49 UTC Artifacts will be uploaded here
2025-09-10 19:18:09 UTC ya make is running...
🟡 2025-09-10 20:32:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31368 29968 0 3 1370 27

2025-09-10 20:35:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-10 20:58:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
251 (only retried tests) 228 0 1 0 22

2025-09-10 20:59:02 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-09-10 21:24:24 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
239 (only retried tests) 216 0 2 0 21

🟢 2025-09-10 21:24:31 UTC Build successful.
🟡 2025-09-10 21:24:50 UTC ydbd size 2.3 GiB changed* by +385.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a313d0d merge: 5c4f31a diff diff %
ydbd size 2 468 384 696 Bytes 2 468 779 184 Bytes +385.2 KiB +0.016%
ydbd stripped size 515 754 952 Bytes 515 821 192 Bytes +64.7 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

2025-09-10 19:17:54 UTC Pre-commit check linux-x86_64-release-asan for 5c4f31a has started.
2025-09-10 19:17:58 UTC Artifacts will be uploaded here
2025-09-10 19:21:22 UTC ya make is running...
🟡 2025-09-10 21:18:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15691 15273 0 135 256 27

🟢 2025-09-10 21:19:49 UTC Build successful.
🟡 2025-09-10 21:20:11 UTC ydbd size 4.0 GiB changed* by +630.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a313d0d merge: 5c4f31a diff diff %
ydbd size 4 317 849 200 Bytes 4 318 494 584 Bytes +630.3 KiB +0.015%
ydbd stripped size 1 493 070 840 Bytes 1 493 258 552 Bytes +183.3 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the vdisk/fix-freeuptolsn-usage branch from cec6cd7 to 5646db1 Compare September 11, 2025 10:36
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

2025-09-11 10:38:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for c075ea4 has started.
2025-09-11 10:39:23 UTC Artifacts will be uploaded here
2025-09-11 10:43:28 UTC ya make is running...
🟡 2025-09-11 12:04:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31368 29950 0 8 1375 35

2025-09-11 12:07:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-11 12:25:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
419 (only retried tests) 398 0 0 0 21

🟢 2025-09-11 12:26:01 UTC Build successful.
🟢 2025-09-11 12:26:17 UTC ydbd size 2.3 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45576be merge: c075ea4 diff diff %
ydbd size 2 468 982 096 Bytes 2 468 982 160 Bytes +64 Bytes +0.000%
ydbd stripped size 515 862 184 Bytes 515 862 248 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

2025-09-11 10:40:14 UTC Pre-commit check linux-x86_64-release-asan for c075ea4 has started.
2025-09-11 10:40:27 UTC Artifacts will be uploaded here
2025-09-11 10:43:49 UTC ya make is running...
🟡 2025-09-11 12:39:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15691 15202 0 157 305 27

🟢 2025-09-11 12:40:33 UTC Build successful.
🟢 2025-09-11 12:40:55 UTC ydbd size 4.0 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 45576be merge: c075ea4 diff diff %
ydbd size 4 318 936 392 Bytes 4 318 936 360 Bytes -32 Bytes -0.000%
ydbd stripped size 1 493 394 104 Bytes 1 493 394 104 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) September 11, 2025 12:45
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexvru alexvru merged commit 0a46d46 into ydb-platform:main Sep 11, 2025
11 checks passed
@alexvru alexvru deleted the vdisk/fix-freeuptolsn-usage branch September 11, 2025 12:48
alexvru added a commit to alexvru/ydb that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants