Skip to content

Stop gRPC server when in DISCONNECTED state #24939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Stop gRPC server when in DISCONNECTED state #24939

merged 1 commit into from
Sep 16, 2025

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 15, 2025 •
edited
Loading

Changelog entry

Stop gRPC server when in DISCONNECTED state

Changelog category

  • Experimental feature

Description for reviewers

This patch makes gRPC server shut down on every node in DISCONNECTED pile. It is started again when pile gets reconnected.

@github-actions
Copy link

github-actions bot commented Sep 15, 2025 •
edited
Loading

⚪ 2025-09-15 10:43:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 479141b has started.
⚪ 2025-09-15 10:44:03 UTC Artifacts will be uploaded here
⚪ 2025-09-15 10:47:28 UTC ya make is running...
🟡 2025-09-15 12:48:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32786 31366 0 7 1372 41

⚪ 2025-09-15 12:51:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-15 13:06:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
650 (only retried tests) 628 0 0 0 22

🟢 2025-09-15 13:06:32 UTC Build successful.
🟢 2025-09-15 13:06:49 UTC ydbd size 2.3 GiB changed* by +75.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: de32cd4 merge: 479141b diff diff %
ydbd size 2 473 413 008 Bytes 2 473 490 496 Bytes +75.7 KiB +0.003%
ydbd stripped size 516 620 328 Bytes 516 636 136 Bytes +15.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 15, 2025 •
edited
Loading

⚪ 2025-09-15 10:43:49 UTC Pre-commit check linux-x86_64-release-asan for 479141b has started.
⚪ 2025-09-15 10:44:04 UTC Artifacts will be uploaded here
⚪ 2025-09-15 10:47:23 UTC ya make is running...
🟡 2025-09-15 13:19:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17059 16628 0 148 252 31

🟢 2025-09-15 13:21:32 UTC Build successful.
🟡 2025-09-15 13:21:58 UTC ydbd size 4.0 GiB changed* by +206.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 101ed14 merge: 479141b diff diff %
ydbd size 4 327 841 392 Bytes 4 328 052 456 Bytes +206.1 KiB +0.005%
ydbd stripped size 1 496 181 112 Bytes 1 496 247 608 Bytes +64.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 15, 2025 •
edited
Loading

🟢 2025-09-15 16:17:53 UTC The validation of the Pull Request description is successful.

@alexvru alexvru force-pushed the 2dc/turn-off-grpc-server-when-disconnected branch from 8b442e1 to 0d075d5 Compare September 15, 2025 17:58
@github-actions
Copy link

github-actions bot commented Sep 15, 2025 •
edited
Loading

⚪ 2025-09-15 18:01:15 UTC Pre-commit check linux-x86_64-release-asan for d20eda8 has started.
⚪ 2025-09-15 18:01:44 UTC Artifacts will be uploaded here
⚪ 2025-09-15 18:05:15 UTC ya make is running...
🟡 2025-09-15 20:26:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17065 16554 0 183 296 32

🟢 2025-09-15 20:28:12 UTC Build successful.
🟡 2025-09-15 20:28:36 UTC ydbd size 4.0 GiB changed* by +119.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 544d830 merge: d20eda8 diff diff %
ydbd size 4 326 507 104 Bytes 4 326 629 568 Bytes +119.6 KiB +0.003%
ydbd stripped size 1 495 886 360 Bytes 1 495 916 152 Bytes +29.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 15, 2025 •
edited
Loading

⚪ 2025-09-15 18:01:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for d20eda8 has started.
⚪ 2025-09-15 18:02:32 UTC Artifacts will be uploaded here
⚪ 2025-09-15 18:06:42 UTC ya make is running...
🟡 2025-09-15 19:46:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32794 30274 0 309 2170 41

⚪ 2025-09-15 19:49:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-15 20:09:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1754 (only retried tests) 713 0 307 711 23

⚪ 2025-09-15 20:09:34 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-09-15 20:25:45 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1295 (only retried tests) 259 0 307 708 21

🟢 2025-09-15 20:26:08 UTC Build successful.
🟢 2025-09-15 20:26:30 UTC ydbd size 2.3 GiB changed* by +65.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 544d830 merge: d20eda8 diff diff %
ydbd size 2 472 762 728 Bytes 2 472 829 728 Bytes +65.4 KiB +0.003%
ydbd stripped size 516 549 640 Bytes 516 556 808 Bytes +7.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru marked this pull request as ready for review September 16, 2025 06:34
@alexvru alexvru marked this pull request as draft September 16, 2025 06:35
@alexvru alexvru force-pushed the 2dc/turn-off-grpc-server-when-disconnected branch from 0d075d5 to fd787d3 Compare September 16, 2025 06:46
@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

⚪ 2025-09-16 06:49:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 91d0842 has started.
⚪ 2025-09-16 06:50:04 UTC Artifacts will be uploaded here
⚪ 2025-09-16 06:53:26 UTC ya make is running...
🟡 2025-09-16 08:19:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32804 31375 0 7 1377 45

⚪ 2025-09-16 08:22:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-16 08:35:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
693 (only retried tests) 670 0 0 3 20

🟢 2025-09-16 08:35:17 UTC Build successful.
🟢 2025-09-16 08:35:34 UTC ydbd size 2.3 GiB changed* by +65.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b45db59 merge: 91d0842 diff diff %
ydbd size 2 473 062 200 Bytes 2 473 129 240 Bytes +65.5 KiB +0.003%
ydbd stripped size 516 594 344 Bytes 516 601 512 Bytes +7.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

⚪ 2025-09-16 06:50:05 UTC Pre-commit check linux-x86_64-release-asan for 91d0842 has started.
⚪ 2025-09-16 06:50:20 UTC Artifacts will be uploaded here
⚪ 2025-09-16 06:53:44 UTC ya make is running...
🟡 2025-09-16 08:53:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17073 16643 0 145 253 32

🟢 2025-09-16 08:54:53 UTC Build successful.
🟡 2025-09-16 08:55:18 UTC ydbd size 4.0 GiB changed* by +123.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b45db59 merge: 91d0842 diff diff %
ydbd size 4 327 001 528 Bytes 4 327 128 080 Bytes +123.6 KiB +0.003%
ydbd stripped size 1 496 024 152 Bytes 1 496 058 040 Bytes +33.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru marked this pull request as ready for review September 16, 2025 08:42
mregrock
mregrock approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexvru alexvru enabled auto-merge (squash) September 16, 2025 08:43
@alexvru alexvru merged commit 9b32775 into ydb-platform:main Sep 16, 2025
12 checks passed
@alexvru alexvru deleted the 2dc/turn-off-grpc-server-when-disconnected branch September 16, 2025 09:12
@alexvru alexvru mentioned this pull request Sep 17, 2025
Merged
alexvru added a commit to alexvru/ydb that referenced this pull request Sep 17, 2025
@alexvru
Stop gRPC server when in DISCONNECTED state (ydb-platform#24939)
d6cb7c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mregrock mregrock mregrock approved these changes

Assignees

No one assigned

Labels

experimental-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexvru @mregrock