Skip to content

block join with neumann ht and packed tuple format #27450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 27, 2025
Merged

block join with neumann ht and packed tuple format #27450

merged 9 commits into from
Oct 27, 2025

Conversation

@nfrmtk
Copy link
Collaborator

@nfrmtk nfrmtk commented Oct 23, 2025 •
edited
Loading

closes: #27182
...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

⚪ 2025-10-23 11:56:10 UTC Pre-commit check linux-x86_64-release-asan for 41008e8 has started.
⚪ 2025-10-23 11:56:24 UTC Artifacts will be uploaded here
⚪ 2025-10-23 11:59:56 UTC ya make is running...
🔴 2025-10-23 12:04:30 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

⚪ 2025-10-23 11:56:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 41008e8 has started.
⚪ 2025-10-23 11:56:26 UTC Artifacts will be uploaded here
⚪ 2025-10-23 12:00:03 UTC ya make is running...
🔴 2025-10-23 12:03:21 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

🟢 2025-10-23 13:08:04 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

⚪ 2025-10-23 12:21:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for b2b38e1 has started.
⚪ 2025-10-23 12:21:36 UTC Artifacts will be uploaded here
⚪ 2025-10-23 12:25:14 UTC ya make is running...
🔴 2025-10-23 12:28:28 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

⚪ 2025-10-23 12:21:29 UTC Pre-commit check linux-x86_64-release-asan for b2b38e1 has started.
⚪ 2025-10-23 12:21:43 UTC Artifacts will be uploaded here
⚪ 2025-10-23 12:25:21 UTC ya make is running...
🔴 2025-10-23 12:30:00 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:42:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5185add has started.
⚪ 2025-10-24 15:42:22 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:46:00 UTC ya make is running...
⚫ 2025-10-24 16:03:56 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 15:44:40 UTC Pre-commit check linux-x86_64-release-asan for 5185add has started.
⚪ 2025-10-24 15:44:54 UTC Artifacts will be uploaded here
⚪ 2025-10-24 15:47:45 UTC ya make is running...
⚫ 2025-10-24 16:04:00 UTC Check cancelled

@nfrmtk nfrmtk marked this pull request as ready for review October 24, 2025 16:03
@nfrmtk nfrmtk requested review from a team as code owners October 24, 2025 16:03
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 16:05:45 UTC Pre-commit check linux-x86_64-release-asan for 0b2ee61 has started.
⚪ 2025-10-24 16:05:59 UTC Artifacts will be uploaded here
⚪ 2025-10-24 16:09:02 UTC ya make is running...
⚫ 2025-10-24 16:10:02 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 16:14:25 UTC Pre-commit check linux-x86_64-release-asan for 8485dfb has started.
⚪ 2025-10-24 16:14:38 UTC Artifacts will be uploaded here
⚪ 2025-10-24 16:17:37 UTC ya make is running...
⚫ 2025-10-24 16:29:33 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 16:14:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8485dfb has started.
⚪ 2025-10-24 16:14:53 UTC Artifacts will be uploaded here
⚪ 2025-10-24 16:18:20 UTC ya make is running...
⚫ 2025-10-24 16:29:34 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 16:35:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0ff59a4 has started.
⚪ 2025-10-24 16:35:38 UTC Artifacts will be uploaded here
⚪ 2025-10-24 16:39:11 UTC ya make is running...
🟡 2025-10-24 18:06:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38616 35822 0 7 2764 23

⚪ 2025-10-24 18:07:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-24 18:29:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
695 (only retried tests) 676 0 1 0 18

⚪ 2025-10-24 18:29:22 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-24 18:51:33 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
433 (only retried tests) 415 0 1 0 17

🟢 2025-10-24 18:51:36 UTC Build successful.
🟢 2025-10-24 18:51:53 UTC ydbd size 2.3 GiB changed* by +54.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7090690 merge: 0ff59a4 diff diff %
ydbd size 2 437 327 344 Bytes 2 437 383 248 Bytes +54.6 KiB +0.002%
ydbd stripped size 518 128 456 Bytes 518 445 512 Bytes +309.6 KiB +0.061%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚪ 2025-10-24 16:37:06 UTC Pre-commit check linux-x86_64-release-asan for 0ff59a4 has started.
⚪ 2025-10-24 16:37:20 UTC Artifacts will be uploaded here
⚪ 2025-10-24 16:40:16 UTC ya make is running...
🟡 2025-10-24 18:42:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15370 14973 0 159 220 18

🟢 2025-10-24 18:42:59 UTC Build successful.
🟡 2025-10-24 18:43:21 UTC ydbd size 3.8 GiB changed* by +692.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7090690 merge: 0ff59a4 diff diff %
ydbd size 4 055 718 920 Bytes 4 056 427 536 Bytes +692.0 KiB +0.017%
ydbd stripped size 1 506 031 392 Bytes 1 507 146 912 Bytes +1.1 MiB +0.074%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

lll-phill-lll
lll-phill-lll previously approved these changes Oct 24, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

⚪ 2025-10-27 07:20:58 UTC Pre-commit check linux-x86_64-release-asan for adb44c0 has started.
⚪ 2025-10-27 07:21:41 UTC Artifacts will be uploaded here
⚪ 2025-10-27 07:23:45 UTC ya make is running...
🟡 2025-10-27 09:36:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15370 14777 0 291 279 23

🟢 2025-10-27 09:36:26 UTC Build successful.
🟡 2025-10-27 09:36:52 UTC ydbd size 3.8 GiB changed* by +872.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 959c4f9 merge: adb44c0 diff diff %
ydbd size 4 055 778 088 Bytes 4 056 671 432 Bytes +872.4 KiB +0.022%
ydbd stripped size 1 506 056 448 Bytes 1 507 247 744 Bytes +1.1 MiB +0.079%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 27, 2025 •
edited
Loading

⚪ 2025-10-27 07:23:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for adb44c0 has started.
⚪ 2025-10-27 07:23:16 UTC Artifacts will be uploaded here
⚪ 2025-10-27 07:24:39 UTC ya make is running...
🟡 2025-10-27 08:52:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38616 35819 0 7 2763 27

⚪ 2025-10-27 08:52:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-27 09:10:03 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
478 (only retried tests) 456 0 0 0 22

🟢 2025-10-27 09:10:05 UTC Build successful.
🟡 2025-10-27 09:10:28 UTC ydbd size 2.3 GiB changed* by +143.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 959c4f9 merge: adb44c0 diff diff %
ydbd size 2 437 356 840 Bytes 2 437 503 544 Bytes +143.3 KiB +0.006%
ydbd stripped size 518 133 768 Bytes 518 473 672 Bytes +331.9 KiB +0.066%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll enabled auto-merge (squash) October 27, 2025 09:58
@lll-phill-lll lll-phill-lll self-requested a review October 27, 2025 11:10
@lll-phill-lll lll-phill-lll merged commit aa1cb3a into ydb-platform:main Oct 27, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hor911 Hor911 Hor911 approved these changes

@lll-phill-lll lll-phill-lll lll-phill-lll approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make use of packed tuple format and neumann hashtable in dq block join(milestone 5)

3 participants

@nfrmtk @Hor911 @lll-phill-lll