-
Notifications
You must be signed in to change notification settings - Fork 735
YQ-4859 fixed streaming queries creation without user token #28193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-4859 fixed streaming queries creation without user token #28193
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors user token handling to make authentication optional throughout the KQP (Kernel Query Processor) system, allowing queries to execute without authentication when no user token is provided.
- Conditionally sets user tokens only when UserSID is present
- Removes authentication requirements from test query clients
- Simplifies token handling by removing serialization helpers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ydb/tests/tools/kqprun/src/ydb_setup.cpp | Adds conditional check to only set user token when UserSID is provided |
| ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp | Removes BUILTIN_ACL_ROOT authentication tokens from test query clients |
| ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp | Refactors user token handling to make it optional and simplifies token serialization logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🟢 |
668ae80 to
256c9f7
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fixed streaming queries creation without user token
Changelog category
Description for reviewers
Bugfix ticket: https://st.yandex-team.ru/YQ-4859