Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

Fixed streaming queries creation without user token

Changelog category

  • Bugfix

Description for reviewers

Bugfix ticket: https://st.yandex-team.ru/YQ-4859

@GrigoriyPA GrigoriyPA requested a review from Hor911 November 4, 2025 09:35
@GrigoriyPA GrigoriyPA requested a review from a team as a code owner November 4, 2025 09:35
Copilot AI review requested due to automatic review settings November 4, 2025 09:35
@github-actions github-actions bot added the bugfix label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

2025-11-04 09:36:57 UTC Pre-commit check linux-x86_64-release-asan for d35ba94 has started.
2025-11-04 09:37:01 UTC Artifacts will be uploaded here
2025-11-04 09:38:29 UTC ya make is running...
🟡 2025-11-04 11:53:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15310 14658 0 313 299 40

🟢 2025-11-04 11:54:07 UTC Build successful.
🟢 2025-11-04 11:54:34 UTC ydbd size 3.8 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 802fb8a merge: d35ba94 diff diff %
ydbd size 4 068 675 512 Bytes 4 068 675 480 Bytes -32 Bytes -0.000%
ydbd stripped size 1 510 375 912 Bytes 1 510 375 656 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

2025-11-04 09:36:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for d35ba94 has started.
2025-11-04 09:37:02 UTC Artifacts will be uploaded here
2025-11-04 09:38:25 UTC ya make is running...
🟡 2025-11-04 11:00:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31439 29996 0 11 1400 32

2025-11-04 11:00:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-04 11:08:17 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 81 0 0 0 13

🟢 2025-11-04 11:08:19 UTC Build successful.
🟢 2025-11-04 11:08:36 UTC ydbd size 2.3 GiB changed* by -592 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 802fb8a merge: d35ba94 diff diff %
ydbd size 2 429 287 080 Bytes 2 429 286 488 Bytes -592 Bytes -0.000%
ydbd stripped size 516 135 944 Bytes 516 135 880 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors user token handling to make authentication optional throughout the KQP (Kernel Query Processor) system, allowing queries to execute without authentication when no user token is provided.

  • Conditionally sets user tokens only when UserSID is present
  • Removes authentication requirements from test query clients
  • Simplifies token handling by removing serialization helpers

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ydb/tests/tools/kqprun/src/ydb_setup.cpp Adds conditional check to only set user token when UserSID is provided
ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp Removes BUILTIN_ACL_ROOT authentication tokens from test query clients
ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp Refactors user token handling to make it optional and simplifies token serialization logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🟢 2025-11-04 09:39:20 UTC The validation of the Pull Request description is successful.

kardymonds
kardymonds previously approved these changes Nov 6, 2025
@GrigoriyPA GrigoriyPA force-pushed the YQ-4859-fix-streaming-queries-creation-without-user-token branch from 668ae80 to 256c9f7 Compare November 6, 2025 08:13
@GrigoriyPA GrigoriyPA requested a review from kardymonds November 6, 2025 08:14
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

2025-11-06 08:15:17 UTC Pre-commit check linux-x86_64-release-asan for cd28457 has started.
2025-11-06 08:15:35 UTC Artifacts will be uploaded here
2025-11-06 08:17:54 UTC ya make is running...
🟡 2025-11-06 10:22:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15389 14874 0 206 277 32

🟢 2025-11-06 10:23:07 UTC Build successful.
🟡 2025-11-06 10:23:35 UTC ydbd size 3.8 GiB changed* by +907.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 759a759 merge: cd28457 diff diff %
ydbd size 4 070 068 208 Bytes 4 070 997 912 Bytes +907.9 KiB +0.023%
ydbd stripped size 1 510 830 024 Bytes 1 511 061 064 Bytes +225.6 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

2025-11-06 08:16:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for cd28457 has started.
2025-11-06 08:16:20 UTC Artifacts will be uploaded here
2025-11-06 08:18:42 UTC ya make is running...
🟡 2025-11-06 09:40:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31511 30097 0 3 1385 26

2025-11-06 09:40:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-06 09:49:01 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56 (only retried tests) 42 0 0 0 14

🟢 2025-11-06 09:49:11 UTC Build successful.
🟡 2025-11-06 09:49:30 UTC ydbd size 2.3 GiB changed* by +603.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bbeaaf5 merge: cd28457 diff diff %
ydbd size 2 430 066 440 Bytes 2 430 684 632 Bytes +603.7 KiB +0.025%
ydbd stripped size 516 259 464 Bytes 516 329 288 Bytes +68.2 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit fe60a68 into ydb-platform:main Nov 6, 2025
12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-4859-fix-streaming-queries-creation-without-user-token branch November 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants