-
Notifications
You must be signed in to change notification settings - Fork 735
make storage balancer async and turned on #28244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@vporyadke привяжи issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the storage balancer by default and makes storage reassignment operations asynchronous to improve performance. The key changes include:
- Updated storage balancer configuration defaults to enable balancing by default
- Made storage balancer reassignments asynchronous
- Updated tests to force synchronous reassignments for deterministic behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/protos/config.proto | Changed default values to enable storage balancer (MinStorageScatterToBalance: 999→0.5, MinGroupUsageToBalance: 0.1→0.05, MaxChannelHistorySize: 200→10) |
| ydb/core/mind/hive/storage_balancer.cpp | Made reassignment operations asynchronous by setting Async flag to true |
| ydb/core/mind/hive/hive_ut.cpp | Added test observers to override async reassignments to synchronous for deterministic test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🟢 |
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Changelog entry
...
Changelog category
Description for reviewers
...