Skip to content

make storage balancer async and turned on #28244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
+11 −3
Merged

make storage balancer async and turned on #28244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73a6324
make storage balancer async and turned on
vporyadke Nov 5, 2025
03a4bda
Update ydb/core/protos/config.proto
vporyadke Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ydb/core/mind/hive/hive_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3330,6 +3330,8 @@ Y_UNIT_TEST_SUITE(THiveTest) {
const ui64 testerTablet = MakeTabletID(false, 1);
CreateTestBootstrapper(runtime, CreateTestTabletInfo(hiveTablet, TTabletTypes::Hive), &CreateDefaultHive);

auto syncReassign = runtime.AddObserver<TEvHive::TEvReassignTablet>([] (auto&& ev) { ev->Get()->Record.SetAsync(false); });

TTabletTypes::EType tabletType = TTabletTypes::Dummy;
TVector<ui64> tablets;
for (ui64 i = 0; i < NUM_TABLETS; ++i) {
Expand Down Expand Up @@ -8991,6 +8993,11 @@ Y_UNIT_TEST_SUITE(TStorageBalanceTest) {
OnBootTablet(info);
return TTestActorRuntime::EEventAction::PROCESS;
}
case TEvHive::EvReassignTablet: {
auto& record = ev->Get<TEvHive::TEvReassignTablet>()->Record;
record.SetAsync(false);
return TTestActorRuntime::EEventAction::PROCESS;
}
}
return TTestActorRuntime::EEventAction::PROCESS;
};
Expand Down
1 change: 1 addition & 0 deletions ydb/core/mind/hive/storage_balancer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ class THiveStorageBalancer : public NActors::TActorBootstrapped<THiveStorageBala
if (!ev) {
ev = std::make_unique<TEvHive::TEvReassignTablet>(channel.TabletId);
ev->Record.SetReassignReason(NKikimrHive::TEvReassignTablet::HIVE_REASSIGN_REASON_BALANCE);
ev->Record.SetAsync(true);
}
ev->Record.AddChannels(channel.ChannelId);
}
Expand Down
6 changes: 3 additions & 3 deletions ydb/core/protos/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2268,10 +2268,10 @@ message THiveConfig {
reserved 66;
optional double ObjectImbalanceToBalance = 67 [default = 0.02];
optional EHiveChannelBalanceStrategy ChannelBalanceStrategy = 68 [default = HIVE_CHANNEL_BALANCE_STRATEGY_WEIGHTED_RANDOM];
optional uint64 MaxChannelHistorySize = 69 [default = 200];
optional uint64 MaxChannelHistorySize = 69 [default = 10];
optional uint64 StorageInfoRefreshFrequency = 70 [default = 600000]; // send a query to BSC every x milliseconds
optional double MinStorageScatterToBalance = 71 [default = 999]; // storage balancer trigger is disabled by default
optional double MinGroupUsageToBalance = 72 [default = 0.1];
optional double MinStorageScatterToBalance = 71 [default = 0.5]; // storage balancer trigger threshold (enabled by default)
optional double MinGroupUsageToBalance = 72 [default = 0.05];
optional uint64 StorageBalancerInflight = 73 [default = 1];
optional bool EnableDestroyOperations = 74 [default = false];
optional double NodeUsageRangeToKick = 75 [default = 0.2];
Expand Down
Loading