-
Notifications
You must be signed in to change notification settings - Fork 738
Fix incorrect PDisk ColorBorder setting #28254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the color occupancy calculation logic in the PDisk chunk tracker by introducing a new convenience method in TPerOwnerQuotaTracker and adding const qualifiers to improve code clarity and maintainability.
- Added
GetOccupancyForColormethod toTPerOwnerQuotaTrackerto encapsulate color occupancy calculation - Made
ColorFlagLimitmethod const-qualified - Replaced direct
ColorLimits.GetOccupancyForColorcalls with the new wrapper method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🟢 |
33055f4 to
d4256ae
Compare
d4256ae to
a83a658
Compare
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
mregrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog category
Description for reviewers
It only affected ICB SemiStrictSpaceIsolation option. After enabling it, the BorderOccupancy was calculated incorrectly (too small). The bug revealed in #28314