Skip to content

Conversation

@rosik
Copy link
Collaborator

@rosik rosik commented Nov 5, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

It only affected ICB SemiStrictSpaceIsolation option. After enabling it, the BorderOccupancy was calculated incorrectly (too small). The bug revealed in #28314

Copilot AI review requested due to automatic review settings November 5, 2025 13:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the color occupancy calculation logic in the PDisk chunk tracker by introducing a new convenience method in TPerOwnerQuotaTracker and adding const qualifiers to improve code clarity and maintainability.

  • Added GetOccupancyForColor method to TPerOwnerQuotaTracker to encapsulate color occupancy calculation
  • Made ColorFlagLimit method const-qualified
  • Replaced direct ColorLimits.GetOccupancyForColor calls with the new wrapper method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

🟢 2025-11-07 13:48:17 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

2025-11-05 15:12:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for f9a72df has started.
2025-11-05 15:12:43 UTC Artifacts will be uploaded here
2025-11-05 15:14:08 UTC ya make is running...
🟡 2025-11-05 17:15:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39810 36974 0 3 2803 30

2025-11-05 17:15:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-05 17:25:52 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76 (only retried tests) 62 0 0 0 14

🟢 2025-11-05 17:25:54 UTC Build successful.
🟢 2025-11-05 17:26:11 UTC ydbd size 2.3 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d793be5 merge: f9a72df diff diff %
ydbd size 2 429 698 736 Bytes 2 429 698 624 Bytes -112 Bytes -0.000%
ydbd stripped size 516 203 144 Bytes 516 203 144 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

2025-11-05 15:12:27 UTC Pre-commit check linux-x86_64-release-asan for f9a72df has started.
2025-11-05 15:12:45 UTC Artifacts will be uploaded here
2025-11-05 15:14:09 UTC ya make is running...
🟡 2025-11-05 17:46:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16217 15815 0 159 215 28

🟢 2025-11-05 17:46:27 UTC Build successful.
🟢 2025-11-05 17:46:50 UTC ydbd size 3.8 GiB changed* by -712 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d793be5 merge: f9a72df diff diff %
ydbd size 4 069 430 064 Bytes 4 069 429 352 Bytes -712 Bytes -0.000%
ydbd stripped size 1 510 663 720 Bytes 1 510 663 208 Bytes -512 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 7, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 7, 2025
@rosik rosik merged commit d206278 into ydb-platform:main Nov 7, 2025
13 checks passed
@rosik rosik deleted the fix-chunk-limits branch November 7, 2025 11:27
ydbot pushed a commit that referenced this pull request Nov 7, 2025
ydbot pushed a commit that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants