Skip to content

Fix check bounds for time extended types #28313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2025
Merged

Fix check bounds for time extended types #28313

merged 5 commits into from
Nov 7, 2025

Conversation

@dahbka-lis
Copy link
Member

@dahbka-lis dahbka-lis commented Nov 6, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This PR fixes two unexpected statuses from BulkUpsert with time extended types (example with Timestamp64):

  1. Upsert Timestamp64(MAX_TIMESTAMP64): BAD_REQUEST but expected SUCCESS.
  2. Upsert Timestamp64(MIN_TIMESTAMP64 - 1): SUCCESS but expected BAD_REQUEST.
    ...

Copilot AI review requested due to automatic review settings November 6, 2025 16:57
@dahbka-lis dahbka-lis requested a review from a team as a code owner November 6, 2025 16:57
@dahbka-lis dahbka-lis linked an issue Nov 6, 2025 that may be closed by this pull request
Implement unit test to verify that incorrect datetime64 values cannot be written into the YDB tables #28274
Closed
@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

🟢 2025-11-07 14:24:56 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

⚪ 2025-11-06 17:00:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 177ea23 has started.
⚪ 2025-11-06 17:00:54 UTC Artifacts will be uploaded here
⚪ 2025-11-06 17:03:09 UTC ya make is running...
🟢 2025-11-06 17:08:29 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
278 277 0 0 0 1

🟢 2025-11-06 17:08:38 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025 •
edited
Loading

⚪ 2025-11-06 17:00:46 UTC Pre-commit check linux-x86_64-release-asan for 177ea23 has started.
⚪ 2025-11-06 17:01:04 UTC Artifacts will be uploaded here
⚪ 2025-11-06 17:03:17 UTC ya make is running...
🟡 2025-11-06 17:18:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
278 276 0 1 0 1

🟢 2025-11-06 17:18:27 UTC Build successful.

Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new parameterized unit test WriteDatetimeValues that validates the writing and reading of Date32, Datetime64, and Timestamp64 values using query parameters for both ROW and COLUMN store tables.

  • Adds comprehensive test coverage for Date32, Datetime64, and Timestamp64 parameter types
  • Tests extreme values including dates far in the past and future, and edge cases
  • Validates both write and read operations with parameterized queries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

⚪ 2025-11-07 13:56:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5df70aa has started.
⚪ 2025-11-07 13:57:16 UTC Artifacts will be uploaded here
⚪ 2025-11-07 13:59:28 UTC ya make is running...
⚫ 2025-11-07 14:23:13 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

⚪ 2025-11-07 13:57:42 UTC Pre-commit check linux-x86_64-release-asan for 5df70aa has started.
⚪ 2025-11-07 13:58:06 UTC Artifacts will be uploaded here
⚪ 2025-11-07 14:00:11 UTC ya make is running...
⚫ 2025-11-07 14:23:13 UTC Check cancelled

@dahbka-lis dahbka-lis requested a review from Copilot November 7, 2025 14:02
@dahbka-lis dahbka-lis changed the title Add a new test for parametrized writes with time extended types Fix check bounds for time extended types Nov 7, 2025
Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

⚪ 2025-11-07 14:23:52 UTC Pre-commit check linux-x86_64-release-asan for bff82a3 has started.
⚪ 2025-11-07 14:26:33 UTC Artifacts will be uploaded here
⚪ 2025-11-07 14:28:40 UTC ya make is running...
🟡 2025-11-07 16:21:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15699 15268 0 167 243 21

🟢 2025-11-07 16:21:28 UTC Build successful.
🟢 2025-11-07 16:21:55 UTC ydbd size 3.8 GiB changed* by +544 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45828a5 merge: bff82a3 diff diff %
ydbd size 4 072 956 144 Bytes 4 072 956 688 Bytes +544 Bytes +0.000%
ydbd stripped size 1 511 824 456 Bytes 1 511 824 520 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

⚪ 2025-11-07 14:27:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for bff82a3 has started.
⚪ 2025-11-07 14:27:13 UTC Artifacts will be uploaded here
⚪ 2025-11-07 14:29:31 UTC ya make is running...
🟡 2025-11-07 15:56:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39301 36479 0 3 2792 27

⚪ 2025-11-07 15:56:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-07 16:06:16 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
57 (only retried tests) 43 0 0 0 14

🟢 2025-11-07 16:06:25 UTC Build successful.
🟢 2025-11-07 16:06:46 UTC ydbd size 2.3 GiB changed* by +416 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 45828a5 merge: bff82a3 diff diff %
ydbd size 2 431 787 888 Bytes 2 431 788 304 Bytes +416 Bytes +0.000%
ydbd stripped size 516 526 256 Bytes 516 526 448 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit self-requested a review November 7, 2025 15:30
@dahbka-lis dahbka-lis enabled auto-merge (squash) November 7, 2025 15:31
@dahbka-lis dahbka-lis merged commit e452dca into ydb-platform:main Nov 7, 2025
13 checks passed
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 10, 2025
@dahbka-lis
Fix check bounds for time extended types (ydb-platform#28313)
41bce1e
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 10, 2025
@dahbka-lis
Fix check bounds for time extended types (ydb-platform#28313)
ed6cdf8
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 10, 2025
@dahbka-lis
Fix check bounds for time extended types (ydb-platform#28313)
dea4f77
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Nov 10, 2025
@dahbka-lis
Fix check bounds for time extended types (ydb-platform#28313)
63c5596
dahbka-lis added a commit that referenced this pull request Nov 10, 2025
@dahbka-lis
[25.2.1] Fix check bounds for time extended types (#28313) (#28537)
03f2539
dahbka-lis added a commit that referenced this pull request Nov 10, 2025
@dahbka-lis
[25.2] Fix check bounds for time extended types (#28313) (#28536)
3451d2c
dahbka-lis added a commit that referenced this pull request Nov 10, 2025
@dahbka-lis
[25.3.1] Fix check bounds for time extended types (#28313) (#28532)
aa8c91b
dahbka-lis added a commit that referenced this pull request Nov 10, 2025
@dahbka-lis
[25.3] Fix check bounds for time extended types (#28313) (#28531)
5632407
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
@dahbka-lis @qyryq
Fix check bounds for time extended types (ydb-platform#28313)
8406b5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement unit test to verify that incorrect datetime64 values cannot be written into the YDB tables

2 participants

@dahbka-lis @gridnevvvit