Skip to content

[25.3] Fix check bounds for time extended types (#28313) #28531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

[25.3] Fix check bounds for time extended types (#28313) #28531

merged 1 commit into from
Nov 10, 2025
+122 −12

Conversation

@dahbka-lis
Copy link
Member

@dahbka-lis dahbka-lis commented Nov 10, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dahbka-lis dahbka-lis requested a review from a team as a code owner November 10, 2025 13:28
@dahbka-lis dahbka-lis linked an issue Nov 10, 2025 that may be closed by this pull request
Implement unit test to verify that incorrect datetime64 values cannot be written into the YDB tables #28274
Closed
@dahbka-lis dahbka-lis changed the title Fix check bounds for time extended types (#28313) [25.3] Fix check bounds for time extended types (#28313) Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

🟢 2025-11-10 13:31:15 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 13:30:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for de37b4b has started.
⚪ 2025-11-10 13:30:41 UTC Artifacts will be uploaded here
⚪ 2025-11-10 13:34:20 UTC ya make is running...
🟡 2025-11-10 15:01:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38440 35767 0 5 2650 18

⚪ 2025-11-10 15:04:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-10 15:20:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
549 (only retried tests) 525 0 4 1 19

⚪ 2025-11-10 15:20:53 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-10 15:37:26 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
543 (only retried tests) 520 0 4 1 18

🟢 2025-11-10 15:37:35 UTC Build successful.
🟢 2025-11-10 15:37:54 UTC ydbd size 2.3 GiB changed* by +480 Bytes, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: 0a5dd67 merge: de37b4b diff diff %
ydbd size 2 440 412 696 Bytes 2 440 413 176 Bytes +480 Bytes +0.000%
ydbd stripped size 522 383 368 Bytes 522 383 624 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 13:34:24 UTC Pre-commit check linux-x86_64-release-asan for de37b4b has started.
⚪ 2025-11-10 13:34:40 UTC Artifacts will be uploaded here
⚪ 2025-11-10 13:38:19 UTC ya make is running...
🟡 2025-11-10 15:49:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15769 15150 0 300 299 20

🟢 2025-11-10 15:50:31 UTC Build successful.
🟢 2025-11-10 15:50:56 UTC ydbd size 3.8 GiB changed* by +608 Bytes, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: 0a5dd67 merge: de37b4b diff diff %
ydbd size 4 061 771 472 Bytes 4 061 772 080 Bytes +608 Bytes +0.000%
ydbd stripped size 1 513 578 304 Bytes 1 513 578 432 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis enabled auto-merge November 10, 2025 13:35
@dahbka-lis dahbka-lis added the rebase-and-check Rebase PR with the current base branch and check label Nov 10, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 16:41:49 UTC Pre-commit check linux-x86_64-release-asan for 86ba664 has started.
⚪ 2025-11-10 16:42:06 UTC Artifacts will be uploaded here
⚪ 2025-11-10 16:45:46 UTC ya make is running...
🟡 2025-11-10 18:53:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15769 15178 0 227 344 20

🟢 2025-11-10 18:54:52 UTC Build successful.
🟢 2025-11-10 18:55:18 UTC ydbd size 3.8 GiB changed* by +608 Bytes, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: c6ddb0f merge: 86ba664 diff diff %
ydbd size 4 061 772 416 Bytes 4 061 773 024 Bytes +608 Bytes +0.000%
ydbd stripped size 1 513 578 624 Bytes 1 513 578 752 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

⚪ 2025-11-10 16:42:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 86ba664 has started.
⚪ 2025-11-10 16:42:45 UTC Artifacts will be uploaded here
⚪ 2025-11-10 16:46:56 UTC ya make is running...
🟡 2025-11-10 18:14:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38440 35762 0 9 2649 20

⚪ 2025-11-10 18:20:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-10 18:37:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
586 (only retried tests) 568 0 1 1 16

⚪ 2025-11-10 18:37:26 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-10 18:50:32 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
539 (only retried tests) 523 0 0 0 16

🟢 2025-11-10 18:50:52 UTC Build successful.
🟢 2025-11-10 18:51:09 UTC ydbd size 2.3 GiB changed* by +480 Bytes, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: c6ddb0f merge: 86ba664 diff diff %
ydbd size 2 440 413 144 Bytes 2 440 413 624 Bytes +480 Bytes +0.000%
ydbd stripped size 522 383 432 Bytes 522 383 688 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis merged commit 5632407 into ydb-platform:stable-25-3 Nov 10, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement unit test to verify that incorrect datetime64 values cannot be written into the YDB tables

2 participants

@dahbka-lis @maximyurchuk