-
Notifications
You must be signed in to change notification settings - Fork 735
Fix docker recipe example #28383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker recipe example #28383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the Docker command example in the documentation by replacing inline comments (which cause syntax errors in bash) with an array-based approach that supports proper commenting.
Key Changes:
- Replaced the multi-line
docker runcommand with backslash continuations and inline comments with a bash array (docker_args) that allows valid bash comments - Separated the command execution into two parts: array definition with comments and the actual
docker runinvocation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/docs/ru/core/reference/docker/start.md | Updated Russian documentation with corrected Docker command syntax using array format |
| ydb/docs/en/core/reference/docker/start.md | Updated English documentation with corrected Docker command syntax using array format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🟢 |
|
⚪
🟢 |
|
⚪
🟢 |
|
Successfully created backport PR for |
(cherry picked from commit 37051ea)
(cherry picked from commit 37051ea)
|
Successfully created backport PR for |
(cherry picked from commit 37051ea)
|
Successfully created backport PR for |
Changelog entry
...
Changelog category
Description for reviewers
...