Skip to content

Conversation

@eivanov89
Copy link
Member

Changelog entry

...

Changelog category

  • Documentation (changelog entry is not required)

Description for reviewers

...

@eivanov89 eivanov89 requested a review from a team as a code owner November 7, 2025 11:10
Copilot AI review requested due to automatic review settings November 7, 2025 11:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Docker command example in the documentation by replacing inline comments (which cause syntax errors in bash) with an array-based approach that supports proper commenting.

Key Changes:

  • Replaced the multi-line docker run command with backslash continuations and inline comments with a bash array (docker_args) that allows valid bash comments
  • Separated the command execution into two parts: array definition with comments and the actual docker run invocation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ydb/docs/ru/core/reference/docker/start.md Updated Russian documentation with corrected Docker command syntax using array format
ydb/docs/en/core/reference/docker/start.md Updated English documentation with corrected Docker command syntax using array format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🟢 2025-11-07 11:11:38 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

2025-11-07 11:11:38 UTC Pre-commit check linux-x86_64-release-asan for a88b502 has started.
2025-11-07 11:12:08 UTC Artifacts will be uploaded here
2025-11-07 11:14:11 UTC ya make is running...
🟢 2025-11-07 11:14:18 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-07 11:14:24 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

2025-11-07 11:12:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for a88b502 has started.
2025-11-07 11:12:42 UTC Artifacts will be uploaded here
2025-11-07 11:14:56 UTC ya make is running...
🟢 2025-11-07 11:15:03 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-07 11:15:09 UTC Build successful.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 7, 2025
@eivanov89 eivanov89 enabled auto-merge (squash) November 7, 2025 14:36
@eivanov89 eivanov89 merged commit 37051ea into ydb-platform:main Nov 10, 2025
13 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Nov 10, 2025

Successfully created backport PR for stable-25-2:

github-actions bot pushed a commit that referenced this pull request Nov 10, 2025
(cherry picked from commit 37051ea)
github-actions bot pushed a commit that referenced this pull request Nov 10, 2025
(cherry picked from commit 37051ea)
@ydbot
Copy link
Collaborator

ydbot commented Nov 10, 2025

Successfully created backport PR for stable-25-3:

github-actions bot pushed a commit that referenced this pull request Nov 10, 2025
(cherry picked from commit 37051ea)
@ydbot
Copy link
Collaborator

ydbot commented Nov 10, 2025

Successfully created backport PR for stable-25-1:

@eivanov89 eivanov89 deleted the fix-docker-example branch November 12, 2025 11:51
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants