-
Notifications
You must be signed in to change notification settings - Fork 735
Large vector tests fixes #28384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large vector tests fixes #28384
Conversation
|
🟢 |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several typos and corrects API usage in vector index tests.
- Corrected spelling errors in function and parameter names
- Fixed incorrect
query()method calls to use proper named parameters (tx=None, stats=Falseinstead of positional boolean) - Refactored code to handle the correct return type from
query()method - Updated test configuration to use minimum cluster value of 2 instead of 1
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/tests/datashard/vector_index/large/test_vector_index_large_levels_and_clusters.py | Fixed typos in test method name and parameter names (vecot→vector, pk_colums→pk_columns, index_colums→index_columns) |
| ydb/tests/datashard/vector_index/large/test_vector_index.py | Corrected query() method calls to use proper named parameters, refactored result handling, and updated clusters test data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Changelog category
Description for reviewers
Closes: #26983