Skip to content

Conversation

@azevaykin
Copy link
Collaborator

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Closes: #26983

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🟢 2025-11-07 11:28:55 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

2025-11-07 11:29:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc1fc14 has started.
2025-11-07 11:29:39 UTC Artifacts will be uploaded here
2025-11-07 11:32:11 UTC ya make is running...
🟢 2025-11-07 11:51:15 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5 5 0 0 0 0

🟢 2025-11-07 11:51:24 UTC Build successful.
🟡 2025-11-07 11:51:39 UTC ydbd size 2.3 GiB changed* by +155.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1d077e2 merge: cc1fc14 diff diff %
ydbd size 2 431 565 824 Bytes 2 431 724 768 Bytes +155.2 KiB +0.007%
ydbd stripped size 516 487 856 Bytes 516 516 592 Bytes +28.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

2025-11-07 11:29:48 UTC Pre-commit check linux-x86_64-release-asan for cc1fc14 has started.
2025-11-07 11:30:05 UTC Artifacts will be uploaded here
2025-11-07 11:32:14 UTC ya make is running...
🟢 2025-11-07 11:44:14 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3 3 0 0 0 0

🟢 2025-11-07 11:44:24 UTC Build successful.
🟡 2025-11-07 11:44:43 UTC ydbd size 3.8 GiB changed* by +217.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: eb551db merge: cc1fc14 diff diff %
ydbd size 4 072 640 024 Bytes 4 072 862 568 Bytes +217.3 KiB +0.005%
ydbd stripped size 1 511 737 192 Bytes 1 511 797 864 Bytes +59.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several typos and corrects API usage in vector index tests.

  • Corrected spelling errors in function and parameter names
  • Fixed incorrect query() method calls to use proper named parameters (tx=None, stats=False instead of positional boolean)
  • Refactored code to handle the correct return type from query() method
  • Updated test configuration to use minimum cluster value of 2 instead of 1

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ydb/tests/datashard/vector_index/large/test_vector_index_large_levels_and_clusters.py Fixed typos in test method name and parameter names (vecot→vector, pk_colums→pk_columns, index_colums→index_columns)
ydb/tests/datashard/vector_index/large/test_vector_index.py Corrected query() method calls to use proper named parameters, refactored result handling, and updated clusters test data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@azevaykin azevaykin enabled auto-merge (squash) November 8, 2025 06:46
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

2025-11-12 06:36:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37055d1 has started.
2025-11-12 06:36:32 UTC Artifacts will be uploaded here
2025-11-12 06:38:49 UTC ya make is running...
🟢 2025-11-12 06:40:11 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5 5 0 0 0 0

🟢 2025-11-12 06:40:18 UTC Build successful.
🟢 2025-11-12 06:40:33 UTC ydbd size 2.3 GiB changed* by +14.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f4b35ec merge: 37055d1 diff diff %
ydbd size 2 440 386 304 Bytes 2 440 400 720 Bytes +14.1 KiB +0.001%
ydbd stripped size 519 114 832 Bytes 519 120 976 Bytes +6.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

2025-11-12 06:36:20 UTC Pre-commit check linux-x86_64-release-asan for 37055d1 has started.
2025-11-12 06:36:37 UTC Artifacts will be uploaded here
2025-11-12 06:38:49 UTC ya make is running...
🟢 2025-11-12 06:40:06 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3 3 0 0 0 0

🟢 2025-11-12 06:40:12 UTC Build successful.
🟢 2025-11-12 06:40:30 UTC ydbd size 3.8 GiB changed* by +25.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f4b35ec merge: 37055d1 diff diff %
ydbd size 4 085 844 800 Bytes 4 085 870 864 Bytes +25.5 KiB +0.001%
ydbd stripped size 1 516 860 424 Bytes 1 516 877 128 Bytes +16.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit 26d0c49 into ydb-platform:main Nov 12, 2025
10 checks passed
@azevaykin azevaykin deleted the LargeVectorTest branch November 12, 2025 07:45
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mute ydb/tests/datashard/vector_index/large 2 tests in main

2 participants