Skip to content

Conversation

@dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Nov 9, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings November 9, 2025 15:00
@dorooleg dorooleg requested a review from a team as a code owner November 9, 2025 15:00
@dorooleg dorooleg requested a review from XJIE6 November 9, 2025 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds memory profiling instrumentation to the TAccessorsParsingTask::DoExecute method by introducing a TMemoryProfileGuard at the beginning of the function execution.

  • Added a TMemoryProfileGuard instance to track memory usage during the execution of TAccessorsParsingTask::DoExecute

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

🟢 2025-11-09 15:04:19 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

2025-11-09 15:04:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a10abb has started.
2025-11-09 15:04:52 UTC Artifacts will be uploaded here
2025-11-09 15:07:20 UTC ya make is running...
🟡 2025-11-09 16:33:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31572 30153 0 4 1388 27

2025-11-09 16:33:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-09 16:41:49 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 46 0 0 0 16

🟢 2025-11-09 16:41:58 UTC Build successful.
🟢 2025-11-09 16:42:19 UTC ydbd size 2.3 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 324c499 merge: 4a10abb diff diff %
ydbd size 2 436 051 312 Bytes 2 436 052 672 Bytes +1.3 KiB +0.000%
ydbd stripped size 517 306 256 Bytes 517 306 512 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

2025-11-09 15:05:37 UTC Pre-commit check linux-x86_64-release-asan for 4a10abb has started.
2025-11-09 15:05:54 UTC Artifacts will be uploaded here
2025-11-09 15:08:12 UTC ya make is running...
🟡 2025-11-09 17:09:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15431 14893 0 260 245 33

🟢 2025-11-09 17:09:40 UTC Build successful.
🟢 2025-11-09 17:10:10 UTC ydbd size 3.8 GiB changed* by +2.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 324c499 merge: 4a10abb diff diff %
ydbd size 4 079 105 320 Bytes 4 079 107 456 Bytes +2.1 KiB +0.000%
ydbd stripped size 1 513 384 072 Bytes 1 513 384 776 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg enabled auto-merge (squash) November 10, 2025 15:04
@dorooleg dorooleg merged commit 07c8576 into ydb-platform:main Nov 10, 2025
18 checks passed
@dorooleg dorooleg deleted the accessors_mem_marking branch November 10, 2025 15:05
dorooleg added a commit to dorooleg/ydb that referenced this pull request Nov 17, 2025
dorooleg added a commit to dorooleg/ydb that referenced this pull request Nov 17, 2025
dorooleg added a commit to dorooleg/ydb that referenced this pull request Nov 17, 2025
dorooleg added a commit to dorooleg/ydb that referenced this pull request Nov 17, 2025
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants