YQ-4867 Add streaming query name to checkpoint metrics #28519
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors checkpoint coordinator metric tracking by replacing the placeholder query_id parameter with an actual path parameter throughout the codebase. The change enables proper identification of streaming queries using their database paths (e.g., "/Root/query1").
- Adds
StreamingQueryPathfield to track query paths across the execution pipeline - Updates test methods to use actual query paths instead of placeholder "query_id" string
- Connects the path information through proto definitions, actors, and execution context
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ydb/tests/fq/streaming/test_streaming.py | Updates test methods to use actual query paths and renames parameter from query_id to path |
| ydb/core/protos/kqp.proto | Adds StreamingQueryPath field to TScriptExecutionOperationMeta |
| ydb/core/kqp/run_script_actor/kqp_run_script_actor.h | Adds StreamingQueryPath to actor settings |
| ydb/core/kqp/run_script_actor/kqp_run_script_actor.cpp | Initializes and passes StreamingQueryPath through actor context |
| ydb/core/kqp/proxy_service/kqp_script_executions.cpp | Propagates StreamingQueryPath through creation and restart operations |
| ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp | Sets StreamingQueryPath when starting streaming queries |
| ydb/core/kqp/executer_actor/kqp_data_executer.cpp | Uses StreamingQueryPath to create subgroup for checkpoint coordinator counters |
| ydb/core/kqp/common/kqp_user_request_context.h | Adds StreamingQueryPath field to user request context |
| ydb/core/kqp/common/events/events.h | Adds StreamingQueryPath field to script request event |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kardymonds
added
the
rebase-and-check
github-actions
bot
removed
the
rebase-and-check
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…uery-name-to-checkpoints-metrics
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
3 participants
Changelog entry
...
Changelog category
Description for reviewers
...