-
Notifications
You must be signed in to change notification settings - Fork 734
Fix segfault when handling ChangeGroupSizeInUnits during VDisk LocalRecovery #28613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functional tests for the PDisk SlotSizeInUnits feature to validate the behavior of dynamic slot sizing for physical disks in the blob storage system.
Key Changes:
- Adds support for
pdisk_configparameter in test harness configuration system - Implements new API methods to query PDisk and storage group information via HTTP
- Adds helper methods to the kikimr client for managing blob storage configurations
- Refactors existing compatibility test to use centralized client methods
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ydb/tests/library/harness/kikimr_runner.py | Adds pdisk_config handling in __add_bs_box method for configuring PDisk settings |
| ydb/tests/library/harness/kikimr_config.py | Adds static_pdisk_config and dynamic_pdisks_config parameters and propagates them through PDisk initialization |
| ydb/tests/library/clients/kikimr_http_client.py | Adds HTTP API methods for querying storage groups and detailed PDisk information |
| ydb/tests/library/clients/kikimr_client.py | Adds blob storage configuration helper methods including read/define host configs, query base config, and update drive status |
| ydb/tests/functional/blobstorage/ya.make | Adds new test file to the build configuration |
| ydb/tests/functional/blobstorage/test_pdisk_slot_size_in_units.py | New test file implementing test cases for PDisk slot sizing feature |
| ydb/tests/compatibility/test_infer_pdisk_expected_slot_count.py | Refactored to use centralized client methods instead of duplicating logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ydb/tests/functional/blobstorage/test_pdisk_slot_size_in_units.py
Outdated
Show resolved
Hide resolved
c954f2f to
c2790a8
Compare
d8f960c to
148ed58
Compare
148ed58 to
9ba70bd
Compare
440dc75 to
cf325a2
Compare
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog category
Description for reviewers
The test revealed the bug. During VDisk LocalRecovery the
PDiskCtxis nullptr, which resulted in a segmentation fault when handlingTEvVGenerationChange. ThePDiskCtxis initialized wen handlingTEvLocalRecoveryDone.