Skip to content

Conversation

@rosik
Copy link
Collaborator

@rosik rosik commented Nov 11, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

The test revealed the bug. During VDisk LocalRecovery the PDiskCtx is nullptr, which resulted in a segmentation fault when handling TEvVGenerationChange. The PDiskCtx is initialized wen handling TEvLocalRecoveryDone.

Copilot AI review requested due to automatic review settings November 11, 2025 09:32
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

🟢 2025-11-18 01:03:37 UTC The validation of the Pull Request description is successful.

Copilot finished reviewing on behalf of rosik November 11, 2025 09:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functional tests for the PDisk SlotSizeInUnits feature to validate the behavior of dynamic slot sizing for physical disks in the blob storage system.

Key Changes:

  • Adds support for pdisk_config parameter in test harness configuration system
  • Implements new API methods to query PDisk and storage group information via HTTP
  • Adds helper methods to the kikimr client for managing blob storage configurations
  • Refactors existing compatibility test to use centralized client methods

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ydb/tests/library/harness/kikimr_runner.py Adds pdisk_config handling in __add_bs_box method for configuring PDisk settings
ydb/tests/library/harness/kikimr_config.py Adds static_pdisk_config and dynamic_pdisks_config parameters and propagates them through PDisk initialization
ydb/tests/library/clients/kikimr_http_client.py Adds HTTP API methods for querying storage groups and detailed PDisk information
ydb/tests/library/clients/kikimr_client.py Adds blob storage configuration helper methods including read/define host configs, query base config, and update drive status
ydb/tests/functional/blobstorage/ya.make Adds new test file to the build configuration
ydb/tests/functional/blobstorage/test_pdisk_slot_size_in_units.py New test file implementing test cases for PDisk slot sizing feature
ydb/tests/compatibility/test_infer_pdisk_expected_slot_count.py Refactored to use centralized client methods instead of duplicating logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iddqdex iddqdex added the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@rosik rosik force-pushed the test-functional-blobstorage branch from c954f2f to c2790a8 Compare November 11, 2025 12:14
alexvru
alexvru previously approved these changes Nov 11, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 11, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 11, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 11, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 11, 2025
@rosik rosik force-pushed the test-functional-blobstorage branch from d8f960c to 148ed58 Compare November 12, 2025 08:32
@rosik rosik force-pushed the test-functional-blobstorage branch from 148ed58 to 9ba70bd Compare November 12, 2025 16:33
@rosik rosik force-pushed the test-functional-blobstorage branch from 440dc75 to cf325a2 Compare November 18, 2025 00:41
@rosik rosik changed the title Add functional test for PDisk SlotSizeInUnits feature Fix segfault when handling ChageGroupSizeInUnits during VDisk LocalRecovery Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

2025-11-18 00:43:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 810d6bd has started.
2025-11-18 00:44:00 UTC Artifacts will be uploaded here
2025-11-18 00:46:44 UTC ya make is running...
🟡 2025-11-18 02:17:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39677 36802 0 4 2842 29

2025-11-18 02:17:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-18 02:32:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72 (only retried tests) 54 0 1 0 17

2025-11-18 02:32:48 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-18 02:40:40 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36 (only retried tests) 21 0 0 0 15

🟢 2025-11-18 02:40:46 UTC Build successful.
🟢 2025-11-18 02:41:07 UTC ydbd size 2.3 GiB changed* by +1008 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d5e1860 merge: 810d6bd diff diff %
ydbd size 2 444 846 160 Bytes 2 444 847 168 Bytes +1008 Bytes +0.000%
ydbd stripped size 519 857 432 Bytes 519 857 816 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rosik rosik changed the title Fix segfault when handling ChageGroupSizeInUnits during VDisk LocalRecovery Fix segfault when handling ChangeGroupSizeInUnits during VDisk LocalRecovery Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

2025-11-18 00:47:49 UTC Pre-commit check linux-x86_64-release-asan for 810d6bd has started.
2025-11-18 00:48:14 UTC Artifacts will be uploaded here
2025-11-18 00:50:55 UTC ya make is running...
🟢 2025-11-18 02:12:09 UTC ydbd size 3.8 GiB changed* by +2.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d5e1860 merge: 810d6bd diff diff %
ydbd size 4 093 155 616 Bytes 4 093 158 144 Bytes +2.5 KiB +0.000%
ydbd stripped size 1 519 640 752 Bytes 1 519 641 968 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@ydb-platform ydb-platform deleted a comment from github-actions bot Nov 18, 2025
@rosik rosik merged commit ceb4975 into ydb-platform:main Nov 19, 2025
16 checks passed
@rosik rosik deleted the test-functional-blobstorage branch November 19, 2025 08:37
@rosik rosik self-assigned this Nov 19, 2025
rosik added a commit to rosik/ydb that referenced this pull request Nov 19, 2025
rosik added a commit to rosik/ydb that referenced this pull request Nov 19, 2025
rosik added a commit to rosik/ydb that referenced this pull request Nov 24, 2025
rosik added a commit to rosik/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants