Skip to content

[ICRDMA] Do not try to disable RDMA if it was not requested. #28618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2025
Merged

[ICRDMA] Do not try to disable RDMA if it was not requested. #28618

merged 1 commit into from
Nov 11, 2025

Conversation

@dcherednik
Copy link
Member

@dcherednik dcherednik commented Nov 11, 2025

Changelog entry

The outgoing hanshake code had wrong logic and expected qp response even in case of regular(without RDMA) handshake.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dcherednik
[ICRDMA] Do not try to disable RDMA if it was not requested.
ff13479 
The outgoing hanshake code had wrong logic and expected qp
response even in case of regular(without RDMA) handshake.
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

🟢 2025-11-11 10:02:18 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 10:03:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 626ac80 has started.
⚪ 2025-11-11 10:03:18 UTC Artifacts will be uploaded here
⚪ 2025-11-11 10:05:30 UTC ya make is running...
🟡 2025-11-11 11:44:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40720 37775 0 20 2887 38

⚪ 2025-11-11 11:45:18 UTC ya make is running... (failed tests rerun, try 2)
🔴 2025-11-11 11:45:21 UTC Build failed, see the logs. Also see fail summary
🟢 2025-11-11 11:45:47 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0e72d0f merge: 626ac80 diff diff %
ydbd size 2 437 870 168 Bytes 2 437 870 168 Bytes 0 Bytes 0.000%
ydbd stripped size 518 656 528 Bytes 518 656 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 10:03:36 UTC Pre-commit check linux-x86_64-release-asan for 626ac80 has started.
⚪ 2025-11-11 10:04:37 UTC Artifacts will be uploaded here
⚪ 2025-11-11 10:06:33 UTC ya make is running...
🟡 2025-11-11 12:05:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17508 16967 0 195 313 33

🟢 2025-11-11 12:06:07 UTC Build successful.
🟢 2025-11-11 12:06:35 UTC ydbd size 3.8 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0e72d0f merge: 626ac80 diff diff %
ydbd size 4 081 237 048 Bytes 4 081 237 112 Bytes +64 Bytes +0.000%
ydbd stripped size 1 515 018 120 Bytes 1 515 018 120 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik enabled auto-merge (squash) November 11, 2025 10:09
@dcherednik dcherednik added the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 13:55:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8d73c3b has started.
⚪ 2025-11-11 13:55:49 UTC Artifacts will be uploaded here
⚪ 2025-11-11 13:57:08 UTC ya make is running...
🟡 2025-11-11 15:33:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40720 37650 0 171 2790 109

⚪ 2025-11-11 15:33:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-11 16:05:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14555 (only retried tests) 11660 0 10 2858 27

⚪ 2025-11-11 16:06:04 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-11 16:39:41 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13450 (only retried tests) 10611 0 23 2794 22

🟢 2025-11-11 16:39:50 UTC Build successful.
🟢 2025-11-11 16:40:15 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8a4d64c merge: 8d73c3b diff diff %
ydbd size 2 437 870 264 Bytes 2 437 870 264 Bytes 0 Bytes 0.000%
ydbd stripped size 518 656 528 Bytes 518 656 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 13:57:26 UTC Pre-commit check linux-x86_64-release-asan for 8d73c3b has started.
⚪ 2025-11-11 13:57:45 UTC Artifacts will be uploaded here
⚪ 2025-11-11 13:59:52 UTC ya make is running...
🟡 2025-11-11 16:00:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17508 16813 0 264 392 39

🟢 2025-11-11 16:00:49 UTC Build successful.
🟢 2025-11-11 16:01:17 UTC ydbd size 3.8 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8a4d64c merge: 8d73c3b diff diff %
ydbd size 4 081 237 432 Bytes 4 081 237 480 Bytes +48 Bytes +0.000%
ydbd stripped size 1 515 018 312 Bytes 1 515 018 312 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik added the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 16:54:29 UTC Pre-commit check linux-x86_64-release-asan for 441099c has started.
⚪ 2025-11-11 16:54:52 UTC Artifacts will be uploaded here
⚪ 2025-11-11 16:56:52 UTC ya make is running...
🟡 2025-11-11 19:08:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17777 17330 0 147 271 29

🟢 2025-11-11 19:09:01 UTC Build successful.
🔴 2025-11-11 19:09:28 UTC ydbd size 3.8 GiB changed* by +3.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: c734e91 merge: 441099c diff diff %
ydbd size 4 081 244 600 Bytes 4 084 372 352 Bytes +3.0 MiB +0.077%
ydbd stripped size 1 515 020 072 Bytes 1 516 379 880 Bytes +1.3 MiB +0.090%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

⚪ 2025-11-11 16:55:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 441099c has started.
⚪ 2025-11-11 16:55:32 UTC Artifacts will be uploaded here
⚪ 2025-11-11 16:57:47 UTC ya make is running...
🟡 2025-11-11 18:52:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41509 38634 0 11 2826 38

⚪ 2025-11-11 18:52:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-11 19:05:41 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 98 0 0 1 19

🟢 2025-11-11 19:05:47 UTC Build successful.
🟢 2025-11-11 19:06:09 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ed7c647 merge: 441099c diff diff %
ydbd size 2 439 429 336 Bytes 2 439 429 336 Bytes 0 Bytes 0.000%
ydbd stripped size 518 928 848 Bytes 518 928 848 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 23bb07f into ydb-platform:main Nov 11, 2025
19 of 21 checks passed
dcherednik added a commit to dcherednik/ydb that referenced this pull request Nov 17, 2025
@dcherednik
[ICRDMA] Do not try to disable RDMA if it was not requested. (ydb-pla…
d756b0a 
…tform#28618)

The outgoing hanshake code had a wrong logic and expected qp response even in case of regular(without RDMA) handshake. This commit fixes it.
dcherednik added a commit that referenced this pull request Nov 19, 2025
@dcherednik
[ICRDMA] Do not try to disable RDMA if it was not requested. (#28618)
d1c0abc 
The outgoing hanshake code had a wrong logic and expected qp response even in case of regular(without RDMA) handshake. This commit fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexvru alexvru alexvru approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcherednik @alexvru