Skip to content

[ICRDMA] Do not try to disable RDMA if it was not requested. #28618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

[ICRDMA] Do not try to disable RDMA if it was not requested. #28618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions ydb/library/actors/interconnect/interconnect_handshake.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,31 +930,34 @@ namespace NActors {
ParsePeerScopeId(success.GetServerScopeId());
}

if (Rdma && success.HasQpPrepared()) {
const auto& remoteQpPrepared = success.GetQpPrepared();
LOG_LOG_IC_X(NActorsServices::INTERCONNECT, "ICRDMA", NLog::PRI_TRACE,
"peer has prepared qp: %d", remoteQpPrepared.GetQpNum());
NInterconnect::NRdma::THandshakeData hd {
.QpNum = remoteQpPrepared.GetQpNum(),
.SubnetPrefix = remoteQpPrepared.GetSubnetPrefix(),
.InterfaceId = remoteQpPrepared.GetInterfaceId(),
.MtuIndex = remoteQpPrepared.GetMtuIndex(),
};
int err = Rdma.Qp->ToRtsState(hd);
if (err) {
TStringBuilder sb;
sb << hd;
if (Rdma) {
if (success.HasQpPrepared()) {
const auto& remoteQpPrepared = success.GetQpPrepared();
LOG_LOG_IC_X(NActorsServices::INTERCONNECT, "ICRDMA", NLog::PRI_TRACE,
"peer has prepared qp: %d", remoteQpPrepared.GetQpNum());
NInterconnect::NRdma::THandshakeData hd {
.QpNum = remoteQpPrepared.GetQpNum(),
.SubnetPrefix = remoteQpPrepared.GetSubnetPrefix(),
.InterfaceId = remoteQpPrepared.GetInterfaceId(),
.MtuIndex = remoteQpPrepared.GetMtuIndex(),
};
int err = Rdma.Qp->ToRtsState(hd);
if (err) {
TStringBuilder sb;
sb << hd;
LOG_LOG_IC_X(NActorsServices::INTERCONNECT, "ICRDMA", NLog::PRI_ERROR,
"Unable to promote QP to RTS, err: %d (%s), handshake data: %s", err, strerror(err), sb.data());
Rdma.HandShakeMemRegion.Reset();
Rdma.Clear();
} else {
Params.ChecksumRdmaEvent = remoteQpPrepared.GetRdmaChecksum();
}
} else {
LOG_LOG_IC_X(NActorsServices::INTERCONNECT, "ICRDMA", NLog::PRI_ERROR,
"Unable to promote QP to RTS, err: %d (%s), handshake data: %s", err, strerror(err), sb.data());
"Non success qp response from remote side");
Rdma.HandShakeMemRegion.Reset();
Rdma.Clear();
}
Params.ChecksumRdmaEvent = remoteQpPrepared.GetRdmaChecksum();
} else {
LOG_LOG_IC_X(NActorsServices::INTERCONNECT, "ICRDMA", NLog::PRI_ERROR,
"Non success qp response from remote side");
Rdma.HandShakeMemRegion.Reset();
Rdma.Clear();
}

// recover peer process info from peer's reply
Expand Down
Loading