Skip to content

Conversation

@serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Nov 11, 2025

Changelog entry

Fix UT

Changelog category

  • Not for changelog (changelog entry is not required)

Copilot AI review requested due to automatic review settings November 11, 2025 14:38
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

2025-11-11 14:39:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7082b56 has started.
2025-11-11 14:39:10 UTC Artifacts will be uploaded here
2025-11-11 14:40:41 UTC ya make is running...
🟢 2025-11-11 14:43:15 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 134 0 0 0 0

🟢 2025-11-11 14:43:22 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

2025-11-11 14:39:15 UTC Pre-commit check linux-x86_64-release-asan for 7082b56 has started.
2025-11-11 14:39:19 UTC Artifacts will be uploaded here
2025-11-11 14:40:40 UTC ya make is running...
🟢 2025-11-11 14:42:11 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-11 14:42:17 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

🟢 2025-11-11 14:39:45 UTC The validation of the Pull Request description is successful.

Copilot finished reviewing on behalf of serbel324 November 11, 2025 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a flaky test TestBlock42PutStatusOkWith_1_1_VdiskErrors by disabling the slow disk acceleration logic in the test environment.

  • Sets SlowDiskThreshold to 1 billion in test environment to prevent inconsistent disk acceleration behavior
  • Removes the test from the muted tests list

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ydb/core/blobstorage/dsproxy/ut/dsproxy_env_mock_ut.h Adds AccelerationParams configuration to disable slow disk detection in test environment
.github/config/muted_ya.txt Unmutes the TestBlock42PutStatusOkWith_1_1_VdiskErrors test
Comments suppressed due to low confidence (1)

ydb/core/blobstorage/dsproxy/ut/dsproxy_env_mock_ut.h:180

  • The second CreatePutRequestActor overload is missing the AccelerationParams configuration that was added to the first overload. For consistency with the test fix, this overload should also include .AccelerationParams = { .SlowDiskThreshold = 1'000'000'000, }, after line 178 to ensure slow disk logic is disabled for batched put requests as well.
    std::unique_ptr<IActor> CreatePutRequestActor(TBatchedVec<TEvBlobStorage::TEvPut::TPtr> &batched,
            TEvBlobStorage::TEvPut::ETactic tactic, NKikimrBlobStorage::EPutHandleClass handleClass)
    {
        TMaybe<TGroupStat::EKind> kind = PutHandleClassToGroupStatKind(handleClass);
        return std::unique_ptr<IActor>(CreateBlobStorageGroupPutRequest(
                TBlobStorageGroupMultiPutParameters{
                    .Common = {
                        .GroupInfo = Info,
                        .GroupQueues = GroupQueues,
                        .Mon = Mon,
                        .Now = TMonotonic::Now(),
                        .StoragePoolCounters = StoragePoolCounters,
                        .RestartCounter = TBlobStorageGroupMultiPutParameters::CalculateRestartCounter(batched),
                        .LatencyQueueKind = kind,
                    },
                    .Events = batched,
                    .TimeStatsEnabled = Mon->TimeStats.IsEnabled(),
                    .Stats = PerDiskStatsPtr,
                    .HandleClass = handleClass,
                    .Tactic = tactic,
                    .EnableRequestMod3x3ForMinLatency = false,
                }));
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serbel324 serbel324 merged commit 6b9cedb into ydb-platform:main Nov 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants