-
Notifications
You must be signed in to change notification settings - Fork 738
Fix TDSProxyPutTest::TestBlock42PutStatusOkWith_1_1_VdiskErrors #28645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TDSProxyPutTest::TestBlock42PutStatusOkWith_1_1_VdiskErrors #28645
Conversation
|
⚪
🟢 |
|
⚪
🟢 |
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a flaky test TestBlock42PutStatusOkWith_1_1_VdiskErrors by disabling the slow disk acceleration logic in the test environment.
- Sets
SlowDiskThresholdto 1 billion in test environment to prevent inconsistent disk acceleration behavior - Removes the test from the muted tests list
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/core/blobstorage/dsproxy/ut/dsproxy_env_mock_ut.h | Adds AccelerationParams configuration to disable slow disk detection in test environment |
| .github/config/muted_ya.txt | Unmutes the TestBlock42PutStatusOkWith_1_1_VdiskErrors test |
Comments suppressed due to low confidence (1)
ydb/core/blobstorage/dsproxy/ut/dsproxy_env_mock_ut.h:180
- The second
CreatePutRequestActoroverload is missing theAccelerationParamsconfiguration that was added to the first overload. For consistency with the test fix, this overload should also include.AccelerationParams = { .SlowDiskThreshold = 1'000'000'000, },after line 178 to ensure slow disk logic is disabled for batched put requests as well.
std::unique_ptr<IActor> CreatePutRequestActor(TBatchedVec<TEvBlobStorage::TEvPut::TPtr> &batched,
TEvBlobStorage::TEvPut::ETactic tactic, NKikimrBlobStorage::EPutHandleClass handleClass)
{
TMaybe<TGroupStat::EKind> kind = PutHandleClassToGroupStatKind(handleClass);
return std::unique_ptr<IActor>(CreateBlobStorageGroupPutRequest(
TBlobStorageGroupMultiPutParameters{
.Common = {
.GroupInfo = Info,
.GroupQueues = GroupQueues,
.Mon = Mon,
.Now = TMonotonic::Now(),
.StoragePoolCounters = StoragePoolCounters,
.RestartCounter = TBlobStorageGroupMultiPutParameters::CalculateRestartCounter(batched),
.LatencyQueueKind = kind,
},
.Events = batched,
.TimeStatsEnabled = Mon->TimeStats.IsEnabled(),
.Stats = PerDiskStatsPtr,
.HandleClass = handleClass,
.Tactic = tactic,
.EnableRequestMod3x3ForMinLatency = false,
}));
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mregrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog entry
Fix UT
Changelog category