Skip to content

Fixed an error in calculating metrics in the PQ tablet (#29321) #29417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

Fixed an error in calculating metrics in the PQ tablet (#29321) #29417

merged 1 commit into from
Nov 25, 2025

Conversation

@nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Nov 24, 2025 •
edited
Loading

Changelog entry

Fixed an error in calculating metrics in the PQ tablet, as a result of which the resource usage was incorrectly determined, which led to unnecessary balancing of tablets.

Changelog category

  • Bugfix

Description for reviewers

LOGBROKER-10121

@nshestakov nshestakov requested a review from a team as a code owner November 24, 2025 10:20
@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

⚪ 2025-11-24 10:22:07 UTC Pre-commit check linux-x86_64-release-asan for dcb1a2c has started.
⚪ 2025-11-24 10:22:22 UTC Artifacts will be uploaded here
⚪ 2025-11-24 10:26:21 UTC ya make is running...

@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

🟢 2025-11-24 10:22:49 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

⚪ 2025-11-24 10:25:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for dcb1a2c has started.
⚪ 2025-11-24 10:26:20 UTC Artifacts will be uploaded here
⚪ 2025-11-24 10:31:01 UTC ya make is running...
🟡 2025-11-24 12:37:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40503 37809 0 17 2653 24

⚪ 2025-11-24 12:41:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-24 13:00:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1521 (only retried tests) 1500 0 1 1 19

⚪ 2025-11-24 13:00:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-24 13:15:27 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
551 (only retried tests) 534 0 0 1 16

🟢 2025-11-24 13:15:36 UTC Build successful.
🟢 2025-11-24 13:15:57 UTC ydbd size 2.3 GiB changed* by -952 Bytes, which is <= 0 Bytes vs stable-25-3: OK

ydbd size dash stable-25-3: b5faea4 merge: dcb1a2c diff diff %
ydbd size 2 441 753 640 Bytes 2 441 752 688 Bytes -952 Bytes -0.000%
ydbd stripped size 522 646 056 Bytes 522 646 248 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge November 24, 2025 14:08
@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Nov 24, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

⚪ 2025-11-24 14:14:54 UTC Pre-commit check linux-x86_64-release-asan for dcb1a2c has started.
⚪ 2025-11-24 14:15:09 UTC Artifacts will be uploaded here
⚪ 2025-11-24 14:18:58 UTC ya make is running...
🟡 2025-11-24 16:33:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17630 17148 0 191 277 14

🟢 2025-11-24 16:34:36 UTC Build successful.
🟢 2025-11-24 16:35:25 UTC ydbd size 3.8 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: b5faea4 merge: dcb1a2c diff diff %
ydbd size 4 064 076 376 Bytes 4 064 084 288 Bytes +7.7 KiB +0.000%
ydbd stripped size 1 514 295 968 Bytes 1 514 301 408 Bytes +5.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

⚪ 2025-11-24 14:17:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for dcb1a2c has started.
⚪ 2025-11-24 14:17:40 UTC Artifacts will be uploaded here
⚪ 2025-11-24 14:21:41 UTC ya make is running...
🟡 2025-11-24 16:01:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40503 37811 0 12 2652 28

⚪ 2025-11-24 16:04:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-24 16:22:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
713 (only retried tests) 692 0 2 1 18

⚪ 2025-11-24 16:22:43 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-24 16:38:33 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
552 (only retried tests) 531 0 1 0 20

🟢 2025-11-24 16:38:42 UTC Build successful.
🟢 2025-11-24 16:39:08 UTC ydbd size 2.3 GiB changed* by -952 Bytes, which is <= 0 Bytes vs stable-25-3: OK

ydbd size dash stable-25-3: b5faea4 merge: dcb1a2c diff diff %
ydbd size 2 441 753 640 Bytes 2 441 752 688 Bytes -952 Bytes -0.000%
ydbd stripped size 522 646 056 Bytes 522 646 248 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Nov 25, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025 •
edited
Loading

⚪ 2025-11-25 08:18:19 UTC Pre-commit check linux-x86_64-release-asan for 82125ab has started.
⚪ 2025-11-25 08:18:35 UTC Artifacts will be uploaded here
⚪ 2025-11-25 08:22:27 UTC ya make is running...
🟡 2025-11-25 10:57:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17730 17227 0 191 294 18

🟢 2025-11-25 10:58:53 UTC Build successful.
🟢 2025-11-25 10:59:24 UTC ydbd size 3.8 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs stable-25-3: OK

ydbd size dash stable-25-3: cc64f5f merge: 82125ab diff diff %
ydbd size 4 064 731 840 Bytes 4 064 739 752 Bytes +7.7 KiB +0.000%
ydbd stripped size 1 514 538 656 Bytes 1 514 544 096 Bytes +5.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 25, 2025 •
edited
Loading

⚪ 2025-11-25 08:18:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 82125ab has started.
⚪ 2025-11-25 08:18:38 UTC Artifacts will be uploaded here
⚪ 2025-11-25 08:22:38 UTC ya make is running...
🟡 2025-11-25 10:28:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40604 37917 0 6 2660 21

⚪ 2025-11-25 10:31:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-25 10:52:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
713 (only retried tests) 692 0 1 1 19

⚪ 2025-11-25 10:52:14 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-11-25 11:08:13 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
548 (only retried tests) 527 0 0 1 20

🟢 2025-11-25 11:08:23 UTC Build successful.
🟢 2025-11-25 11:08:42 UTC ydbd size 2.3 GiB changed* by -960 Bytes, which is <= 0 Bytes vs stable-25-3: OK

ydbd size dash stable-25-3: cc64f5f merge: 82125ab diff diff %
ydbd size 2 442 066 080 Bytes 2 442 065 120 Bytes -960 Bytes -0.000%
ydbd stripped size 522 717 736 Bytes 522 717 928 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit fa180ee into ydb-platform:stable-25-3 Nov 25, 2025
19 of 22 checks passed
@nshestakov nshestakov deleted the PQ-counters-25-3 branch November 25, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nshestakov @maximyurchuk @alexnick88