Skip to content

Conversation

@pixcc
Copy link
Member

@pixcc pixcc commented Nov 25, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

For #29462

Copilot AI review requested due to automatic review settings November 25, 2025 10:21
@pixcc pixcc requested a review from a team as a code owner November 25, 2025 10:21
@pixcc pixcc linked an issue Nov 25, 2025 that may be closed by this pull request
@github-actions
Copy link

🟢 2025-11-25 10:23:55 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

2025-11-25 10:25:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for b742f57 has started.
2025-11-25 10:25:39 UTC Artifacts will be uploaded here
2025-11-25 10:27:57 UTC ya make is running...
🟢 2025-11-25 10:28:03 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-25 10:28:09 UTC Build successful.

@pixcc pixcc enabled auto-merge (squash) November 25, 2025 10:25
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

2025-11-25 10:25:48 UTC Pre-commit check linux-x86_64-release-asan for b742f57 has started.
2025-11-25 10:26:05 UTC Artifacts will be uploaded here
2025-11-25 10:28:13 UTC ya make is running...
🟢 2025-11-25 10:28:19 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-25 10:28:25 UTC Build successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a changelog entry documenting a bug fix for the ydb tools restore command that could crash due to a mutex lock failure caused by an internal race condition. The fix was implemented in PR #29462.

  • Adds a new changelog entry describing the bug fix for the restore command crash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Added a new `--output` option to the `ydb admin cluster state fetch` command. The new option specify path to the output .tar.bz2 file.
* Added a simple progress bar for non-interactive stderr.
* Added a new `omit-indexes` property to the `--item` option of the `ydb tools copy` command, allowing tables to be copied without their indexes.
* Fixed a bug where the `ydb tools restore` command could crash with an `mutex lock failure (Invalid argument)` error due to an internal race condition.
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error: Should be "a mutex lock failure" instead of "an mutex lock failure" because "mutex" starts with a consonant sound.

Suggested change
* Fixed a bug where the `ydb tools restore` command could crash with an `mutex lock failure (Invalid argument)` error due to an internal race condition.
* Fixed a bug where the `ydb tools restore` command could crash with a `mutex lock failure (Invalid argument)` error due to an internal race condition.

Copilot uses AI. Check for mistakes.
@pixcc pixcc merged commit 92f9641 into ydb-platform:main Nov 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ydb tools restore: Acquire(): requirement result == 0 failed

2 participants