Fixed wrong output for large DT64* values in UI #29524
Conversation
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This PR fixes the formatting of large Date32, Datetime64, and Timestamp64 values in the viewer UI by replacing std::format calls with custom formatting functions that properly handle the full range of these extended time types without overflow.
Key changes:
- Added custom formatting functions (
FormatDate32,FormatDatetime64,FormatTimestamp64) that manually format time values to avoidstd::formatoverflow issues - Replaced
std::formatcalls with the new custom formatters inColumnPrimitiveValueToJsonValue - Added a comment in the example code warning about potential overflow issues with standard output and
std::format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ydb/public/sdk/cpp/examples/time/main.cpp | Added comment documenting potential overflow issues with standard output for large timestamp values |
| ydb/core/viewer/viewer_query.h | Implemented custom formatting functions for Date32/Datetime64/Timestamp64 types and replaced std::format calls to handle large values correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Gazizonoki
changed the title
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 participants
Changelog entry
...
Changelog category
Description for reviewers
...