Skip to content

Configure infer_pdisk_slot_count with ydb_configure #29778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

Configure infer_pdisk_slot_count with ydb_configure #29778

merged 1 commit into from
Dec 1, 2025
+41 −0

Conversation

@rosik
Copy link
Collaborator

@rosik rosik commented Nov 28, 2025 •
edited
Loading

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

https://nda.ya.ru/t/OpGy4dCK7Nu85s

Copilot AI review requested due to automatic review settings November 28, 2025 14:30
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

⚪ 2025-11-28 14:32:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for de01ec5 has started.
⚪ 2025-11-28 14:32:50 UTC Artifacts will be uploaded here
⚪ 2025-11-28 14:34:06 UTC ya make is running...
🟡 2025-11-28 14:35:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 17 0 1 0 0

⚪ 2025-11-28 14:35:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-28 14:49:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

⚪ 2025-11-28 14:49:46 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-28 14:50:45 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2025-11-28 14:50:52 UTC Build successful.
🟢 2025-11-28 14:51:11 UTC ydbd size 2.3 GiB changed* by +57.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5f0309b merge: de01ec5 diff diff %
ydbd size 2 458 920 784 Bytes 2 458 980 072 Bytes +57.9 KiB +0.002%
ydbd stripped size 523 796 776 Bytes 523 807 208 Bytes +10.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copilot finished reviewing on behalf of rosik November 28, 2025 14:32
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

🟢 2025-11-30 23:36:02 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

⚪ 2025-11-28 14:33:23 UTC Pre-commit check linux-x86_64-release-asan for de01ec5 has started.
⚪ 2025-11-28 14:33:41 UTC Artifacts will be uploaded here
⚪ 2025-11-28 14:35:00 UTC ya make is running...
🟡 2025-11-28 14:36:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 9 0 1 0 0

🟢 2025-11-28 14:36:39 UTC Build successful.

Copilot AI reviewed Nov 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring infer_pdisk_slot_count settings through ydb_configure. The feature allows configuring automatic PDisk slot count inference based on unit size and maximum slot limits for different drive types (SSD/NVME and ROT).

Key Changes:

  • Added extraction and storage of infer_pdisk_slot_count configuration from blob_storage_config
  • Implemented application of infer settings to host configurations in both static and dynamic config generation
  • Extended KiKiMRDrive and HostConfig classes to support the new infer parameters

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
ydb/tools/cfg/base.py Adds infer_pdisk_slot_count parameters to KiKiMRDrive and HostConfig classes, and extracts these settings from blob_storage_config
ydb/tools/cfg/static.py Implements _apply_infer_pdisk_slot_count_to_host_config to apply infer settings to host configurations in the normalized config, and removes infer settings from blob_storage_config output
ydb/tools/cfg/dynamic.py Adds _get_infer_settings_for_drive method and modifies drive configuration to include infer parameters when generating dynamic configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rosik rosik force-pushed the kikimr-configure-infer-pdisk-params branch 2 times, most recently from 423cf5f to 53ca840 Compare November 28, 2025 14:52
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

⚪ 2025-11-28 14:56:15 UTC Pre-commit check linux-x86_64-release-asan for f0abf64 has started.
⚪ 2025-11-28 14:56:39 UTC Artifacts will be uploaded here
⚪ 2025-11-28 15:07:53 UTC ya make is running...
🟡 2025-11-28 15:09:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 9 0 1 0 0

🟢 2025-11-28 15:09:30 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

⚪ 2025-11-28 14:56:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0abf64 has started.
⚪ 2025-11-28 14:56:45 UTC Artifacts will be uploaded here
⚪ 2025-11-28 14:59:00 UTC ya make is running...
🟡 2025-11-28 15:00:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 17 0 1 0 0

⚪ 2025-11-28 15:00:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-11-28 15:15:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

⚪ 2025-11-28 15:16:06 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-11-28 15:17:12 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2025-11-28 15:17:19 UTC Build successful.
🟢 2025-11-28 15:17:40 UTC ydbd size 2.3 GiB changed* by +52.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a439de8 merge: f0abf64 diff diff %
ydbd size 2 458 926 752 Bytes 2 458 980 072 Bytes +52.1 KiB +0.002%
ydbd stripped size 523 797 800 Bytes 523 807 208 Bytes +9.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

mregrock
mregrock previously approved these changes Nov 28, 2025
View reviewed changes
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosik rosik enabled auto-merge (squash) November 28, 2025 15:04
@rosik rosik disabled auto-merge November 30, 2025 22:21
@rosik rosik force-pushed the kikimr-configure-infer-pdisk-params branch from 53ca840 to c391f05 Compare November 30, 2025 22:21
@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 22:25:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1bee5c4 has started.
⚪ 2025-11-30 22:25:35 UTC Artifacts will be uploaded here
⚪ 2025-11-30 22:27:49 UTC ya make is running...
🟢 2025-11-30 22:29:04 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 18 0 0 0 0

🟢 2025-11-30 22:29:12 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 22:26:10 UTC Pre-commit check linux-x86_64-release-asan for 1bee5c4 has started.
⚪ 2025-11-30 22:26:27 UTC Artifacts will be uploaded here
⚪ 2025-11-30 22:28:30 UTC ya make is running...
🟢 2025-11-30 22:29:56 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 10 0 0 0 0

🟢 2025-11-30 22:30:02 UTC Build successful.

@rosik rosik force-pushed the kikimr-configure-infer-pdisk-params branch from c391f05 to c0baaf3 Compare November 30, 2025 22:45
@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 22:48:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for e73dd9f has started.
⚪ 2025-11-30 22:49:05 UTC Artifacts will be uploaded here
⚫ 2025-11-30 22:50:31 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 22:49:16 UTC Pre-commit check linux-x86_64-release-asan for e73dd9f has started.
⚪ 2025-11-30 22:49:32 UTC Artifacts will be uploaded here
⚫ 2025-11-30 22:50:31 UTC Check cancelled

@rosik rosik force-pushed the kikimr-configure-infer-pdisk-params branch from c0baaf3 to ae3c791 Compare November 30, 2025 22:50
@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 22:51:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for f81c34f has started.
⚪ 2025-11-30 22:51:51 UTC Artifacts will be uploaded here
⚪ 2025-11-30 22:53:58 UTC ya make is running...
🟢 2025-11-30 22:55:09 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 18 0 0 0 0

🟢 2025-11-30 22:55:16 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 22:54:24 UTC Pre-commit check linux-x86_64-release-asan for f81c34f has started.
⚪ 2025-11-30 22:54:40 UTC Artifacts will be uploaded here
⚪ 2025-11-30 22:56:43 UTC ya make is running...
🟢 2025-11-30 22:58:08 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 10 0 0 0 0

🟢 2025-11-30 22:58:15 UTC Build successful.

@rosik rosik closed this Nov 30, 2025
@rosik rosik force-pushed the kikimr-configure-infer-pdisk-params branch from ae3c791 to 8efc84b Compare November 30, 2025 23:21
@rosik rosik reopened this Nov 30, 2025
@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 23:28:34 UTC Pre-commit check linux-x86_64-release-asan for d0bac00 has started.
⚪ 2025-11-30 23:28:44 UTC Artifacts will be uploaded here
⚪ 2025-11-30 23:30:02 UTC ya make is running...
🟢 2025-11-30 23:31:22 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 10 0 0 0 0

🟢 2025-11-30 23:31:29 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 23:29:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for d0bac00 has started.
⚪ 2025-11-30 23:29:22 UTC Artifacts will be uploaded here
⚪ 2025-11-30 23:31:29 UTC ya make is running...
🟢 2025-11-30 23:32:41 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 18 0 0 0 0

🟢 2025-11-30 23:32:48 UTC Build successful.

@rosik rosik force-pushed the kikimr-configure-infer-pdisk-params branch from e5ac44f to bb7429a Compare November 30, 2025 23:47
@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 23:52:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc50b26 has started.
⚪ 2025-11-30 23:53:07 UTC Artifacts will be uploaded here
⚪ 2025-11-30 23:54:39 UTC ya make is running...
🟢 2025-11-30 23:55:43 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 18 0 0 0 0

🟢 2025-11-30 23:55:50 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 00:28:13 UTC Pre-commit check linux-x86_64-release-asan for dc50b26 has started.
⚪ 2025-12-01 00:28:31 UTC Artifacts will be uploaded here
⚪ 2025-12-01 00:30:35 UTC ya make is running...
🟢 2025-12-01 00:32:00 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 10 0 0 0 0

🟢 2025-12-01 00:32:06 UTC Build successful.

mregrock
mregrock approved these changes Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosik rosik merged commit 73c09d0 into ydb-platform:main Dec 1, 2025
9 checks passed
@rosik rosik deleted the kikimr-configure-infer-pdisk-params branch December 1, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mregrock mregrock mregrock approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rosik @mregrock