fix: test runner cleanup + fanout timestamp bounded discovery#413
Merged
Conversation
Test runner: - Fix mocha arg parsing (split --timeout from value) - Default to **/*.spec.ts when no spec args provided - Remove describe.only from strider.spec.ts - Remove it.only from strider rollback test - Fix hook.spec.ts blockTime to be recent (within 7-day lookback) Fanout: - Replace unbounded DISTINCT block_time scan with series_time bounded query on the output table, scoped to the fanout window. - Maps to the top pg_stat_statements offender.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
murderteeth
approved these changes
May 28, 2026
Contributor
murderteeth
left a comment
There was a problem hiding this comment.
Summary
Two unrelated fixes bundled, split from #400:
- Test runner: fix mocha
--timeoutarg splitting, default to**/*.spec.tsfallback, dropdescribe.only/it.onlyfrom strider, bumphook.spec.tsblockTime into the 7-day lookback window. - Fanout timestamp discovery: replace unbounded
DISTINCT block_timescan with aseries_timerange-bounded scan onoutput, returning epoch seconds directly. Aligns with the hypertable partition column for chunk pruning.
Issues
None blocking.
Follow-ups (not blockers, separate from this PR)
packages/lib/types.spec.tsis broken on disk — Removing the.onlycalls instrider.spec.tscorrectly unmasks every other lib spec, which surfaces a pre-existing failure:OutputSchema.parse({ address: '0x', ... })is rejected byEvmAddressSchema → viem.getAddress. The test fixture hasaddress: '0x', which has never been a valid checksum address. Either fix the fixture (use a real address) or loosen the schema. Worth fixing soon sobun --filter lib testgoes back to exit 0.bun --filter ingest testdiscovery is broken (pre-existing) —packages/ingest/run-tests.ts(unchanged here) uses the same['**/*.spec.ts']fallback withspawn(..., { shell: true }). Bash'sglobstaris off by default, so**collapses to*and only depth-2 specs are discovered (abis/index.spec.ts,extract/evmlogs.spec.ts). Top-level (things.spec.ts,prices.spec.ts,abiutil.spec.ts) and depth-3+ specs are silently skipped — including thehook.spec.tsblockTime fix in this PR atabis/yearn/2/strategy/snapshot/hook.spec.ts. The fix itself is correct, but the runner doesn't exercise it. Options: dropshell: trueand let mocha's own glob handle**, prefix the shell withshopt -s globstar, or pre-expand with a JS glob lib.
Verdict
APPROVE
How This Was Reviewed
This review was conducted using the review-pr skill.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split from #400 per review feedback — smaller, independently measurable changes.
Test runner cleanup
--timeoutfrom value)**/*.spec.tswhen no spec args provideddescribe.onlyfromstrider.spec.ts(was still there on the old branch)it.onlyfrom strider rollback testhook.spec.tsblockTime to be recent (within 7-day lookback window)Fanout timestamp discovery
DISTINCT block_timescan withseries_timebounded query on the output table, scoped to the fanout windowpg_stat_statementsoffender — the 99%+ row-reduction winFrom
Split from #400 (PR 1+2 per review request)
Follow-ups (surfaced during review)
types.spec.tsfixture (pre-existing, unmasked by the.onlyremoval)bun --filter ingest testsilently skips most specs (shell globstar default-off; pre-existing inpackages/ingest/run-tests.ts)