Skip to content

Fix stale governance proposal alerts#263

Merged
spalen0 merged 1 commit into
dockerfrom
fix/proposal-monitor-stale-alerts
Jun 4, 2026
Merged

Fix stale governance proposal alerts#263
spalen0 merged 1 commit into
dockerfrom
fix/proposal-monitor-stale-alerts

Conversation

@spalen0
Copy link
Copy Markdown
Collaborator

@spalen0 spalen0 commented Jun 4, 2026

Summary

  • fix Aave proposal monitor to alert only governance-executed proposals that still have pending payloads, using Aave governance cache API payload state across chains
  • exclude cancelled proposals and fully executed payload sets like proposal 488, while including pending examples like proposal 489
  • harden Maker, Fluid, and Compound proposal monitors around cache updates, Markdown escaping, payload validation, timeouts, and processing errors
  • add focused proposal monitor regression tests

Verification

Aave Governance v3 state Executed = 4 means vote results were sent and payloads were created/queued, not necessarily that every payload has executed. The monitor now fetches governance-executed proposals from the subgraph, then checks Aave governance cache payload states and only reports proposals where at least one payload is not executed.

Local debug run updated /srv/cache/cache-id.txt to aave:489 with Telegram skipped by LOG_LEVEL=DEBUG.

Tests

  • uv run --extra dev pytest tests/test_aave_proposals.py tests/test_fluid_proposals.py tests/test_maker_proposals.py tests/test_compound_proposals.py -q
  • uv run ruff check aave/proposals.py fluid/proposals.py maker/proposals.py compound/proposals.py tests/test_aave_proposals.py tests/test_fluid_proposals.py tests/test_maker_proposals.py tests/test_compound_proposals.py

@spalen0 spalen0 force-pushed the fix/proposal-monitor-stale-alerts branch 2 times, most recently from bd12e20 to 142376d Compare June 4, 2026 11:30
@spalen0 spalen0 force-pushed the fix/proposal-monitor-stale-alerts branch from 142376d to 621a6c9 Compare June 4, 2026 11:32
@spalen0 spalen0 merged commit 0e4d374 into docker Jun 4, 2026
@spalen0 spalen0 deleted the fix/proposal-monitor-stale-alerts branch June 4, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant