#502: Fixed IndexedAbsent to preserve identity and transaction state#503
Merged
rultor merged 1 commit intoyegor256:masterfrom Feb 17, 2026
Merged
#502: Fixed IndexedAbsent to preserve identity and transaction state#503rultor merged 1 commit intoyegor256:masterfrom
rultor merged 1 commit intoyegor256:masterfrom
Conversation
Owner
|
@rultor merge |
Collaborator
Collaborator
@belfil @yegor256 Oops, I failed. You can see the full log here (spent 1min). |
Contributor
Author
|
@yegor256 Conflicts resolved. |
Owner
|
@rultor merge |
Collaborator
Collaborator
|
@belfil Thank you for your contribution! You've earned +16 points for this submission: +24 as the base reward, +8.775 for the 117 hits-of-code you wrote (capped at +16), then reduced to the maximum allowed +24 points, which is then capped at +16 to stay within policy limits. Please keep them coming! Your running score is +570; don't forget to check your Zerocracy account too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #502
Summary of Changes
This PR fixes a bug where
IndexedAbsentfailed to correctly find all facts with duplicate property values, especially when inserted inside a transaction.Changes
IndexedAbsentto correctly store and retrieve all facts, even if they share identical property values.uniq(&:object_id)to the result mapping to ensure distinct facts are preserved while avoiding duplicate entries for a single fact with multiple matching values._feedto process only new facts since the last indexing cycle.TapedandLazyTapedvia therepackmethod.