fix: add proper token authentication to mobile server#10
Merged
Conversation
Security issue: The mobile server currently rejects all requests without X-Mobile-Token header, including public assets and status endpoint that should be accessible without authentication. Changes: - Add validate_token() helper that checks X-Mobile-Token header, query parameter (?token=...), and Cookie header - Exempt public routes from auth: GET /, GET /assets/*, GET /api/mobile/status - Include token in status response and Settings UI for easy access - Add 6 test cases covering token validation, public routes, and rejection This ensures legitimate clients can access public endpoints while still protecting sensitive API routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a security issue where the mobile server rejects all requests without the
X-Mobile-Tokenheader, including public assets and the status endpoint that should be accessible without authentication.Changes
validate_token()helper that checks token from:X-Mobile-Tokenheader (existing)?token=...query parameter (new)Cookieheader (new)GET /(root)GET /assets/*(static assets)GET /api/mobile/status(status endpoint)Test Plan
Impact
This ensures legitimate clients can access public endpoints while still protecting sensitive API routes.