Make SetEncryptionMethod public#7
Closed
kdungs wants to merge 5 commits into
Closed
Conversation
- Rename variables for consistency - Remove comments stating the obvious - Remove internal/* dependencies from tests - Replace some Errorf() to Fatalf() calls in tests to avoid panics - Update documentation, license - General cleanup
This is necessary if a user wants to use CreateHeader effectively e.g. because they want to set the last modified date on the files.
Owner
|
#4 has been merged. It exposes SetEncryptionMethod. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Yeka,
I found this to be necessary in order to use CreateHeader which I needed to set the last modified date on files added to an encrypted zip file.
If this is misguided and there's a better way, please educate me and drop this PR :)
Cheers,
Kevin