Implement - SearchView #67 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekang42
approved these changes
Nov 9, 2021
Collaborator
hekang42
left a comment
hekang42
left a comment
There was a problem hiding this comment.
snap carousel 은 홈화면이나 여러모로 쓸모있을듯
고생했어 !
jinbekim
reviewed
Nov 9, 2021
jinbekim
approved these changes
Nov 9, 2021
Contributor
jinbekim
left a comment
jinbekim
left a comment
There was a problem hiding this comment.
봐도 잘 모르겠네요 .나중에 설명해 주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snap carousel 때문에 view model에 index가 추가 되었습니다.
snap carousel이 너무 어렵기도 하고 search view에서 그렇게 필요한 아이인가 싶기도 하고...
일단 같이 넣어는 놨지만 추후 디자인 나오는거 봐서 필요하지 않다면 없애도 좋을 것 같습니다 ㅋㅋ