Added the bulk copy to remote resources#377
Conversation
|
Would you guys care if I snuck some other tests for the remote functionality into this PR? It looks like I could copy and paste my new tests but have them call the standard remote methods and get better coverage in there. But if I did two PR's I would have conflicts. It is not a big deal for me, but it would make them harder to merge for you. Just wondering... |
lib/actions/actions.js
Outdated
Not at all, add a new commit with more test if that works for you. |
|
Hey, this looks good to me. Only changes, is that I'll made the Otherwise, that looks good to merge for the 0.14.0-rc2 |
|
@wesleytodd You around? I'd like to merge this in before 0.14 |
|
Hey @SBoudrias, sorry I have been busy with work the past week. I can probably do that by wednesday night if that works for you. Sorry about being un-responsive, but as I am sure you know, paying work comes first. |
|
Hey, I merged it in as is. That's mostly because, I played around this test file a bit, and it is quite ugly... It'd need a major restructure and rethink to make each test independant. Soooo, I told myself, lets merge and see to improve that later on. Thanks for the good work! |
|
Thanks @SBoudrias. I agree that that file could use some refactoring, just writing the bulk tests was a pain because of the tests that were trying to copy the entire fixtures directory. Anyway, glad I could help. |
|
Thanks @wesleytodd :) |
This is a continuation of #350 & #359. Added the new bulk operations to the remote resources. I had to mess with the way that the source root was used in the original implementation because the conflicter wait's till next tick to run, which reset the
sourceRootbefore the copy actually took place. But other than that it is just a proxy to the new methods.